Bug 1679877

Summary: [ALL_LANG except zh_CN] Column names are truncated on network -> network -> clusters -> manage networks screen.
Product: [oVirt] ovirt-engine Reporter: Bhushan Barve <bbarve>
Component: Frontend.WebAdminAssignee: eraviv
Status: CLOSED CURRENTRELEASE QA Contact: Bhushan Barve <bbarve>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.3.0CC: amusil, bbarve, bugs, danken, dholler, mburman, sgratch
Target Milestone: ovirt-4.4.0Keywords: i18n
Target Release: 4.4.0Flags: pm-rhel: ovirt-4.4?
bbarve: planning_ack?
pm-rhel: devel_ack+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-08-05 06:09:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
es_ES truncation
none
ja_JP_column_truncation none

Description Bhushan Barve 2019-02-22 06:20:19 UTC
Created attachment 1537337 [details]
es_ES truncation

Description of problem: For all locales except zh_CN, there's truncation observed for column names on network -> network -> clusters -> manage networks screen. The cells are not resizeable thus column names are truncated. Please refer attached screenshots. 

Version-Release number of selected component (if applicable):
4.3.0.4-0.1.el7

How reproducible:
always

Steps to Reproduce:
1. Login to admin portal with any locale other than zh_CN
2. Go to network -> network -> clusters -> manage networks 
3. Check the column names

Actual results:
The column names are truncated. The cells are not resizeable.

Expected results:
The column names should be visible fully.

Additional info:

Comment 1 Bhushan Barve 2019-02-22 06:21:11 UTC
Created attachment 1537338 [details]
ja_JP_column_truncation

Comment 2 Dan Kenigsberg 2019-02-26 11:49:25 UTC
In my opinion we should only make the vertical lines movable by users who want to see what is hidden.

Would that be simple, Ales?

Comment 3 Ales Musil 2019-02-28 08:56:32 UTC
(In reply to Dan Kenigsberg from comment #2)
> In my opinion we should only make the vertical lines movable by users who
> want to see what is hidden.
> 
> Would that be simple, Ales?

Not sure about the simplicity, but this change sounds like the whole webadmin specific rather then only for one dialog.

Comment 4 Dominik Holler 2019-11-26 14:52:39 UTC
Sharon, can you please have a look?

Comment 5 Sharon Gratch 2019-12-03 13:54:30 UTC
(In reply to Dominik Holler from comment #4)
> Sharon, can you please have a look?

It doesn't seem to me like a general webAdmin issue. You need to specifically handle this popup dialog to fit all locales.
I suggest setting the last column width to be a bit larger (it seems like the only one required that) and also enable manual resizing of those columns within the grid (i.e. vertical lines movable by users).

This should be done on ClusterManageNetworkPopupView::initEntityModelCellTable() by adding something like:

/* For enabling columns resizing by the user: */
@@ -89,6 +89,7 @@
private void initEntityModelCellTable() {
         boolean multiCluster = networks.asEditor().flush().isMultiCluster();

+        networks.enableColumnResizing();
 
/* For resizing last column DefaultRouteNetworkIndicatorCheckboxColumn from 120px to 250px: */
@@ -128,7 +129,7 @@ 
     public class ClusterManageNetworkPopupView extends AbstractModelBoundPopupView<C
         networks.addColumn(
                 new DefaultRouteNetworkIndicatorCheckboxColumn(
                         multiCluster, new DefaultRouteNetworkIndicatorFieldUpdater()),
-                constants.defaultRouteNetwork(), "120px"); //$NON-NLS-1$
+                constants.defaultRouteNetwork(), "250px"); //$NON-NLS-1$
     }

Comment 7 Bhushan Barve 2020-07-09 07:30:15 UTC
Checked with -  4.4.1.8-0.7.el8ev 버전 
With the columns resizable now, user can see the column names properly.
Marking it as verified.

Comment 8 Sandro Bonazzola 2020-08-05 06:09:55 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.