Bug 1680271

Summary: Remove the deprecated "openshift_logging_curator_run_timezone" variable on v3.11
Product: OpenShift Container Platform Reporter: Daein Park <dapark>
Component: LoggingAssignee: Jeff Cantrill <jcantril>
Status: CLOSED ERRATA QA Contact: Anping Li <anli>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.11.0CC: aos-bugs, dapark, rmeggins
Target Milestone: ---   
Target Release: 3.11.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: logging-curator has been changed to be scheduled by CronJob, times are based the timezone of the master where the job is initiated. So "openshift_logging_curator_run_timezone" variable can not configure the timezone anymore. Consequence: "openshift_logging_curator_run_timezone" does not work, and the variable naming cause confusion to others. Fix: "openshift_logging_curator_run_timezone" is removed from related playbooks and docs. Result: "openshift_logging_curator_run_timezone" will not used anymore.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-15 05:44:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Daein Park 2019-02-23 14:24:10 UTC 
Description of problem:

The curator is triggered by CronJob as of v3.11 instead of a running pod [0], 
so "openshift_logging_curator_run_timezone" variable is not used on v3.11 and can not control over the running timezone on curator.

For suppressing confusion, remove the deprecated ansible variable.

[0] [https://github.com/openshift/origin-aggregated-logging/tree/master/curator#compatibility-with-openshift-37]
~~~
In earlier releases admins could control the timezone and time when curator runs from the curator config. 
This configuration has been moved to openshift-ansible. The timezone is not currently configurable, instead the timezone of OpenShift master node is used.
~~~

Version-Release number of the following components:
rpm -q openshift-ansible

  openshift-ansible-3.11.59-1.git.0.ba8e948.el7.noarch

rpm -q ansible

  ansible-2.6.11-1.el7ae.noarch

ansible --version

  ansible 2.6.11
    config file = /etc/ansible/ansible.cfg
    configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
    ansible python module location = /usr/lib/python2.7/site-packages/ansible
    executable location = /usr/bin/ansible
    python version = 2.7.5 (default, Sep 12 2018, 05:31:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]

How reproducible:

Always, even though "openshift_logging_curator_run_timezone" is configured, the CronJob is triggered by timezone which is running master controllers.

Steps to Reproduce:
1.
2.
3.

Actual results:

N/A

Expected results:

N/A

Additional info:

https://bugzilla.redhat.com/show_bug.cgi?id=1677454#c3
~~~
Between 3.10 and 3.11 we switched from custom implementation of cron to official k8s cronjob controller.
Run hour and run minute are no longer environmental variables of the pod, but are part of the cronjob configuration.
https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_logging_curator/tasks/main.yaml#L92

Kubernetes cronjob controller uses timezone of the host, which is why we don't configure it directly from curator playbook any more. As documented in https://github.com/openshift/origin-aggregated-logging/tree/master/curator#compatibility-with-openshift-37

@Daein Park, please wait for https://github.com/openshift/openshift-ansible/pull/11211 to merge and then close this bz.
~~~
Comment 6 Anping Li 2019-03-01 09:59:00 UTC 
Verified with openshift-ansible:v3.11.88
Comment 8 Luke Meyer 2020-05-15 05:44:12 UTC 
This should have been closed due to errata shipping. Closing now.