Bug 1680293

@Siddhant When you manually add a volume in a pool libvirt is not aware of it.
Verify yourself: If you execute virsh vol-list $MY_POOL you will not see your new volume there. You can make it visible by virsh pool-refresh $POOL_NAME.

This is essentially what we are doing when user is deleting volumes from cockpit UI. Same, once we 'll implement the feature to add a storage volume to an existing pool, we will refresh the pool after adding the volumes.

Regarding the refresh button I think it is not good idea to get implemented. Once the functionality to add volumes from cockpit UI is in, there will not be need for explicit refresh, it will be called internally.
For the time being, since you are already on terminal to add the new image, you can probably just do the refresh there as well, instead of clicking a button from UI.

Let me know if you agree.

@Katerina,

I have no issue's with what you ask , I just thought It would be a good feature to include if some sort of manual intervention if required , say for example if the volume , say a multipath device goes missing , then will libvirt understand that the volume is missing suddenly and remove it's entry from the UI?. or will it still show until you run virsh pool-refresh $POOL_NAME.

Just asking for curiosity.

Also it would be much more user friendly since a lot of end users may not know the command "virsh pool-refresh $POOL_NAME". However it's not a tough find.

If adding / removing is going to trigger the refresh , then well I have no problem with not implementing it, However will it handle such cases as mentioned above where due to some unforeseen reasons , the volume is not present?.

@Siddhant no, if a volume will get removed manually, or anyhow except from within the cockpit UI, the UI will not update, simply because libvirt does not offer events for Storage Volumes.
So, let's leave this feature request open. Thanks!

Adjusting the title to be more appropriate. This is blocked by missing libvirt API by now.

Indeed we won't add "Refresh" buttons to Cockpit. If needed, just use the general browser Reload button/key.

Fixed by:

commit 026dd4f08e7d130aa6b9d2df0669c8aa1bf39b6c
Author: Katerina Koukiou <kkoukiou>
Date:   Thu Jul 11 11:22:44 2019 +0200

    machines: when fetching storage pools refresh them first if they are active

$ git describe 026dd4
198-67-g026dd4f08

Now, plain reload of the browser page will refresh pool data.

Yunming, can you please QA ack? I'd like to backport that fix into RHEL 8.1.

Test Versions:
cockpit-machines-197.1-1.el8.noarch
libvirt-dbus-1.2.0-2.module+el8.1.0+2983+b2ae9c0a.x86_64


Test Steps:
1. Login cockpit
2. Prepare a storage pool, then check the storage pool and the volumes in this pool through UI
3. Create a disk manually, just like ‘qemu-img create -f qcow2 {vol-bane}.qcow2 1G’
4. Check the volumes in the storage pool through UI
5. Refresh the page, re-check the volumes in the storage pool through UI

Test Results:
1. After step4, the volume which is created manually is not shown on the UI.
2. After step5, the volume which is created manually is shown on the UI.

According to the results, move the status to VERIFIED.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3325