Bug 1683118

Summary:	Incorrect document for set_iothread in Domain.pm
Product:	Red Hat Enterprise Linux Advanced Virtualization	Reporter:	Dan Zheng <dzheng>
Component:	perl-Sys-Virt	Assignee:	Daniel Berrangé <berrange>
Status:	CLOSED ERRATA	QA Contact:	Dan Zheng <dzheng>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.0	Keywords:	Automation
Target Milestone:	rc
Target Release:	8.0
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Sys-Virt-5.6.0-1.module+el8.1.0+3895+267fb0f4	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-06 07:12:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Zheng 2019-02-26 09:47:31 UTC

Description of problem:
Incorrect document for set_iothread in Domain.pm

Version-Release number of selected component (if applicable):
perl-Sys-Virt-5.0.0-1.module+el8+2734+e0d8b77e.x86_64

How reproducible:
100%

Steps to Reproduce:
1. 
In lib/Sys/Virt/Domain.pm, 

$dom->set_iothread($iothread, $params, $nparams, $flags=0)

But $nparams is unused here and should be removed, otherwise it will lead incorrect usage for this API. 

2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Daniel Berrangé 2019-03-21 13:36:35 UTC

Fixed upstream in so we'll get it when rebasing to 5.1.0 or newer:

commit 96a3ad9d80e0c7f313dc1e541df1d22b163f7d4d
Author: Dan Zheng <dzheng>
Date:   Tue Feb 26 17:40:49 2019 +0800

    Remove the unused parameter in document
    
    Signed-off-by: Dan Zheng <dzheng>

Comment 3 Dan Zheng 2019-08-30 07:12:39 UTC

Verified in perl-Sys-Virt-5.6.0-1.module+el8.1.0+3908+8a8c5ed4.x86_64

Check the code and find it is fixed already.

=item $dom->set_iothread($iothread, $params, $flags=0)

Comment 5 errata-xmlrpc 2019-11-06 07:12:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3723