Bug 168381

Summary:	Review Request: rpy - python interface to R
Product:	[Fedora] Fedora	Reporter:	José Matos <jamatos>
Component:	Package Review	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	alex, fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://rpy.sourceforge.net
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-23 17:00:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description José Matos 2005-09-15 15:16:33 UTC

Spec Url: http://www.fc.up.pt/pessoas/jamatos/fedora-extras/rpy.spec
SRPM Url: http://www.fc.up.pt/pessoas/jamatos/fedora-extras/rpy-0.4.6-1.src.rpm

Description:
RPy provides a robust Python interface to the R
programming language.  It can manage all kinds of R objects and can
execute arbitrary R functions. All the errors from the R language are
converted to Python exceptions.

Comment 1 Tom "spot" Callaway 2005-09-15 15:45:09 UTC

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED.

Comment 2 Alex Lancaster 2005-09-20 03:28:03 UTC

Please add a Bugzilla component for "rpy" to owners CVS as per new package process.

Also new Bugzilla components don't appear to be being created so I am going to
file a package bug here. 

The issue is that the info docs aren't being built.  Rather than distribute
manual.texi in /usr/share/doc/examples/rpy-0.4.6/, the package should build and
install the manual to /usr/share/info/ so that it browseable via info.

Lastly, since the package has been built and pushed to the mirrors, shouldn't it
be CLOSED and marked CURRENTRELEASE?

Comment 3 Alex Lancaster 2005-09-22 00:18:26 UTC

(In reply to comment #2)
> Please add a Bugzilla component for "rpy" to owners CVS as per new package
process.

Seems to be added now, and the cron job to create components is now working again.

> Also new Bugzilla components don't appear to be being created so I am going to
> file a package bug here. 

Opened new bug on this:  bug #169002

Comment 4 José Matos 2005-09-23 17:00:04 UTC

Thanks for your input. :-) 
 
I have add the component to owners, and I will close the bug here since, 
as you said, the package build cleanly. 
 
I will refer to the bug in the proper entry.