Bug 1683866

Summary:	hub bash completion should be moved out of /etc
Product:	[Fedora] Fedora	Reporter:	Chris King-Parra <chris>
Component:	hub	Assignee:	Stephen Gallagher <sgallagh>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	29	CC:	rbean, sgallagh
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	hub-2.10.0-2.fc29 hub-2.10.0-2.fc28 hub-2.10.0-2.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-12 22:18:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris King-Parra 2019-02-28 02:20:47 UTC

Description of problem:

  The bash completion file for this package is installed as
'/etc/bash_completion.d/hub.bash_completion.sh'. According
to the FHS, files under '/etc/' are for changes by the local
administrator only. It should be under '/usr/share' instead.

  I suggest the completion script should be installed as
'/usr/share/bash-completion/completions/hub', to match the
convention used by the 'bash-completion' package. Many
(most?) other packages also use this convention, like
'libvirt-bash-completion', for example.

Version-Release number of selected component (if applicable):
  2.9.0

How reproducible:
  Always

Steps to Reproduce:
1. Install hub:              'dnf install hub'
2. List the packages files:  'rpm -ql hub | grep completion'

Actual results:
  '/etc/bash_completion.d/hub.bash_completion.sh'

Expected results:
  '/usr/share/bash-completion/completions/hub'

Comment 1 Stephen Gallagher 2019-02-28 13:38:15 UTC

Yes, you're absolutely right. I'll get to that soon.

Comment 2 Fedora Update System 2019-02-28 20:56:49 UTC

hub-2.10.0-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-943f7324d5

Comment 3 Fedora Update System 2019-02-28 20:56:54 UTC

hub-2.10.0-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-943f7324d5

Comment 4 Fedora Update System 2019-02-28 20:56:58 UTC

hub-2.10.0-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2b703f1ce6

Comment 5 Fedora Update System 2019-02-28 20:57:04 UTC

hub-2.10.0-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2b703f1ce6

Comment 6 Fedora Update System 2019-02-28 20:57:09 UTC

hub-2.10.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-457661b041

Comment 7 Fedora Update System 2019-02-28 20:57:12 UTC

hub-2.10.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-457661b041

Comment 8 Fedora Update System 2019-03-02 00:24:47 UTC

hub-2.10.0-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-943f7324d5

Comment 9 Fedora Update System 2019-03-02 00:58:25 UTC

hub-2.10.0-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2b703f1ce6

Comment 10 Fedora Update System 2019-03-02 02:05:22 UTC

hub-2.10.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-457661b041

Comment 11 Fedora Update System 2019-03-12 22:18:08 UTC

hub-2.10.0-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2019-03-17 07:20:19 UTC

hub-2.10.0-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2019-03-17 07:24:41 UTC

hub-2.10.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.