Bug 1683868

Summary:	fzf bash completion script should be moved to /usr/share
Product:	[Fedora] Fedora	Reporter:	Chris King-Parra <chris>
Component:	fzf	Assignee:	Elliott Sales de Andrade <quantum.analyst>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	29	CC:	go-sig, quantum.analyst
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	fzf-0.18.0-1.fc30 fzf-0.18.0-1.fc29	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-04-07 00:01:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris King-Parra 2019-02-28 02:32:52 UTC

Description of problem:

  The bash completion file for this package is installed as
'/etc/bash_completion.d/fzf'. According to the FHS, files 
under '/etc/' are for changes by the local administrator
only. It should be under '/usr/share' instead.

  I suggest the completion script should be installed as
'/usr/share/bash-completion/completions/fzf', to match the
convention used by the 'bash-completion' package. Many
(most?) other packages also use this convention, like
'libvirt-bash-completion', for example.

Version-Release number of selected component (if applicable):
  Version: 0.17.5
  Release: 2.fc.29

How reproducible:
  Always.

Steps to Reproduce:
1. Install fzf:             'dnf install fzf'
2. List the packages files: 'rpm -ql fzf | grep completion'

Actual results:
   '/etc/bash_completion.d/fzf'

Expected results:
   '/usr/share/bash-completion/completions/fzf'

Comment 1 Elliott Sales de Andrade 2019-02-28 09:55:17 UTC

Oh, I thought I did this already. I will probably leave it until the next upstream release to change though.

Comment 2 Fedora Update System 2019-04-01 07:28:11 UTC

fzf-0.18.0-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0780ef0106

Comment 3 Fedora Update System 2019-04-01 07:28:57 UTC

fzf-0.18.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-af48fe176b

Comment 4 Fedora Update System 2019-04-02 02:07:04 UTC

fzf-0.18.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-af48fe176b

Comment 5 Fedora Update System 2019-04-02 02:29:48 UTC

fzf-0.18.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0780ef0106

Comment 6 Fedora Update System 2019-04-07 00:01:09 UTC

fzf-0.18.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2019-04-10 07:36:19 UTC

fzf-0.18.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.