Bug 1683895

Alice, can you take a look... doesn't look like it should be too tricky to resolve.

(In reply to Yongcheng Yang from comment #0)
> ...
> As soon as the Bug 1683101 got fixed, i.e., the `redhat-release`
> package had already added nfsconvert.service to the presets.

This bug depends on this redhat-release bug (with NO progress for now):

https://bugzilla.redhat.com/show_bug.cgi?id=1683895

Having read through the associated tickets this looks like it is pending a decision on the correct way to implement it rather than needing a fix, a decision that still seems unresolved from  https://bugzilla.redhat.com/show_bug.cgi?id=1673685 despite that ticket being closed.

As far as I can see nfs-utils is not part of the minimal install, it certainly has no other mentions in the systemd presets, which would make it wrong to add nfsconvert to the presets as I presume it would create a dependancy thus growing the minimal install.

Is there some reason that the rules in nfs-convert.service do not already handle things, so we can just drop this from the spec file entirely?

And given that, why are there other manual calls to systemctl in the %post rules of the spec file? shouldn't they also already be handled by the dependancies?

Unless there is some known reason why the spec file calls to systemctl are still needed I will remove them and test that the services files adequately do the job instead.

My apologies.... I just don't see what the problem is here...

(In reply to Yongcheng Yang from comment #0)
> ...
> As soon as the Bug 1683101 got fixed, i.e., the `redhat-release`
> package had already added nfsconvert.service to the presets.
> 

The redhat-release-8.3-0.2.el8 has enabled nfs-convert now:
~~~~~~~~~~~~~~~~~~~~~~~~
etoot@rhel-8-3-latest ~]# tail -2 /usr/lib/systemd/system-preset/90-default.preset
# https://bugzilla.redhat.com/show_bug.cgi?id=1683101
enable nfs-convert.service
etoot@rhel-8-3-latest ~]# rpm -qf /usr/lib/systemd/system-preset/90-default.preset
redhat-release-8.3-0.2.el8.x86_64

This is no necessary in nfs-utils.spec %post code to enable it once again:

> # Enable nfs-convert so if an old configuration 
> # exists a conversion will occur
> /bin/systemctl enable nfs-convert  >/dev/null 2>&1 || :

(In reply to Yongcheng Yang from comment #8)
> 
> The redhat-release-8.3-0.2.el8 has enabled nfs-convert now:
> ~~~~~~~~~~~~~~~~~~~~~~~~
> etoot@rhel-8-3-latest ~]# tail -2
> /usr/lib/systemd/system-preset/90-default.preset
> # https://bugzilla.redhat.com/show_bug.cgi?id=1683101
> enable nfs-convert.service
> etoot@rhel-8-3-latest ~]# rpm -qf
> /usr/lib/systemd/system-preset/90-default.preset
> redhat-release-8.3-0.2.el8.x86_64
> 
> This is no necessary in nfs-utils.spec %post code to enable it once again:
> 
> > # Enable nfs-convert so if an old configuration 
> > # exists a conversion will occur
> > /bin/systemctl enable nfs-convert  >/dev/null 2>&1 || :

No need to enable nfs-convert in spec file as it's enabled by `redhat-release` presets.

Confirmed that nfs-convert is enabled by default now, no need to keep this in the spec file

Verified on the latst nfs-utils:

[root@ ~]# rpm -q nfs-utils
nfs-utils-2.3.3-40.el8.x86_64
[root@ ~]# rpm -q nfs-utils --scripts | grep nfs-convert
[root@ ~]# systemctl is-enabled nfs-convert
enabled
[root@ ~]#

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nfs-utils bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1669