Bug 1684190

Summary: ristretto spits Glib error on window resize
Product: [Fedora] Fedora Reporter: Jeremy Harris <jeharris>
Component: ristrettoAssignee: Mukundan Ragavan <nonamedotc>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 29CC: kevin, martin.sourada, nonamedotc, rosset.filipe
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ristretto-0.8.5-1.fc30 ristretto-0.8.5-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-29 01:08:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jeremy Harris 2019-02-28 16:40:07 UTC
Description of problem:

 (ristretto:13795): GLib-CRITICAL **: 16:29:30.867: Source ID 33 was not found when attempting to remove it



Version-Release number of selected component (if applicable):
  ristretto 0.8.3

How reproducible:
  frequesnt

Steps to Reproduce:
1. resize ristretto window
2. check terminal window used for starting ristretto
3.

Actual results:
 Error message (presumably on stderr)

Expected results:
 Silence


Additional info:

 1540 ?        SLsl   0:00 /usr/sbin/lightdm
 1682 tty1     Ssl+  22:04  \_ /usr/libexec/Xorg -core -noreset :0 -seat seat0 -auth /var/run/lightdm/root/:0 -nolisten tcp vt1 -novtswitch
 1937 ?        Sl     0:00  \_ lightdm --session-child 12 19
 2022 ?        Ss     0:00      \_ /bin/sh /etc/xdg/xfce4/xinitrc -- vt
 2189 ?        Ss     0:00          \_ /usr/bin/ssh-agent /bin/sh -c exec -l /bin/bash -c "startxfce4"
 2220 ?        Sl     0:07          \_ xfce4-session
 2298 ?        S      0:00              \_ xterm -xtsessionID 2cd33d5eb-d05f-4a10-842b-d7b5df7aa976
 2426 pts/6    Ss     0:00              |   \_ bash
13795 pts/6    Sl     0:57              |       \_ ristretto host_segotk0112.plotnetcfg.svg vm_segotl2894.plotnetcfg.svg net_diagrampng.png

Comment 1 Kevin Fenzi 2019-03-10 17:52:46 UTC
Would you be willing to file this upstream at bugzilla.xfce.org?

Or would you prefer we do so?

I assume, despite the message, that the application keeps running?

Comment 2 Jeremy Harris 2019-03-11 09:00:10 UTC
I'd be happy for you to handle the upstream - thanks.  Yes, the ristretto application appears unaffected by the error (hence the low Severity).

Comment 3 Kevin Fenzi 2019-04-07 20:59:42 UTC
https://bugzilla.xfce.org/show_bug.cgi?id=15268

Sorry this took so long to get back around to.

Comment 4 Filipe Rosset 2019-07-18 03:36:17 UTC
This issue was fixed in ristretto-0.8.4, can you please double check if we can go ahead and close this issue?

https://git.xfce.org/apps/ristretto/commit?id=b2e6b0563bf04ec68b11aea5761cd9d5f8578f31

Thanks.

Comment 5 Jeremy Harris 2019-07-18 08:43:57 UTC
That version does not seem to be in Fedora yet?

$ sudo dnf provides ristretto
Last metadata expiration check: 0:32:15 ago on Thu 18 Jul 2019 09:02:55 BST.
ristretto-0.8.3-21.fc30.x86_64 : Image-viewer for the Xfce desktop environment
Repo        : @System
Matched from:
Provide    : ristretto = 0.8.3-21.fc30

ristretto-0.8.3-21.fc30.x86_64 : Image-viewer for the Xfce desktop environment
Repo        : fedora
Matched from:
Provide    : ristretto = 0.8.3-21.fc30

Comment 6 Filipe Rosset 2019-07-18 18:15:42 UTC
(In reply to Kevin Fenzi from comment #3)
> https://bugzilla.xfce.org/show_bug.cgi?id=15268
> 
> Sorry this took so long to get back around to.

Kevin/Mukundan can we build 0.8.5 an push an update to F30+?

Looks like 0.8.4 was built, but not sent as update, we're still in 0.8.3 on F30 atm.

Comment 7 Mukundan Ragavan 2019-07-18 22:00:45 UTC
I am building now. I merged your PR this morning but had to leave for work.

Comment 8 Filipe Rosset 2019-07-18 22:08:39 UTC
(In reply to Mukundan Ragavan from comment #7)
> I am building now. I merged your PR this morning but had to leave for work.

no problem, thanks :-)

Comment 9 Fedora Update System 2019-07-18 23:27:50 UTC
FEDORA-2019-a8861b886e has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a8861b886e

Comment 10 Fedora Update System 2019-07-18 23:27:50 UTC
FEDORA-2019-4667fdf346 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4667fdf346

Comment 11 Fedora Update System 2019-07-19 01:34:48 UTC
ristretto-0.8.5-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4667fdf346

Comment 12 Fedora Update System 2019-07-19 03:25:59 UTC
ristretto-0.8.5-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a8861b886e

Comment 13 Fedora Update System 2019-07-29 01:08:20 UTC
ristretto-0.8.5-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2019-07-29 01:44:55 UTC
ristretto-0.8.5-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.