Bug 1684195

Summary:	[RFE] Add summary section at the end of the log files
Product:	[oVirt] ovirt-hosted-engine-setup	Reporter:	Ido Rosenzwig <irosenzw>
Component:	General	Assignee:	Ido Rosenzwig <irosenzw>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Liran Rotenberg <lrotenbe>
Severity:	low	Docs Contact:
Priority:	medium
Version:	---	CC:	bugs, guillaume.pavese, lrotenbe, stirabos
Target Milestone:	ovirt-4.3.2	Flags:	sbonazzo: ovirt-4.3? sbonazzo: devel_ack+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-hosted-engine-setup-2.3.6	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-19 10:03:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ido Rosenzwig 2019-02-28 16:53:41 UTC

Description of problem:

Hosted-engine logs are hard to read and use for debugging a failed deployment.
In addition, because there are ansible tasks that are being skipped and added to the log, it is difficult for a user to track the tasks that were actually got executed and understand the deployment flow.

Thus, we should add a summary section at the end of each ansible log file that will show all the tasks that weren't skipped at the order they were executed.
Also, we should print the duration time for each task, for it is a valuable information that we can use for debugging and statistics.

On a failed deployment we should mark the task that has failed, helping the user find the source of the problem quickly - without searching the entire log for keywords like 'fail', 'error', etc...

Steps to Reproduce:
1. Running: '$ hosted-engine --deploy'
2. In the bottom of each (ansible) log file in /var/log/ovirt-hosted-engine-setup/ the summary section should appear
3.

Comment 1 Ido Rosenzwig 2019-02-28 20:23:38 UTC

example of a log file :
https://jenkins.ovirt.org/job/ovirt-system-tests_manual/4180/artifact/exported-artifacts/test_logs/he-basic-suite-master/post-002_bootstrap.py/lago-he-basic-suite-master-host-0/_var_log/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup-ansible-create_target_vm-20190228124614-32mvuh.log

Comment 2 Liran Rotenberg 2019-03-07 09:50:12 UTC

Verified on:
ovirt-hosted-engine-setup-2.3.6-1.el7ev.noarch

Steps:
1. Deploy HE environment.
2. Check logs under /var/log/ovirt-hosted-engine-setup

Results:
On each log of ansible there is a summary section at the bottom of the log, indicating the time of a task and what the task is.

Comment 3 Sandro Bonazzola 2019-03-19 10:03:25 UTC

This bugzilla is included in oVirt 4.3.2 release, published on March 19th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.