Bug 1684357

Hi @Xingxing Xia, for 'Should use 4.0 approach to update "controllerArguments" (still need investigate how to)', do you have any information on the 4.x approach for updating "controllerArguments"? Thanks!

oc edit kubecontrollermanager cluster`:
...snipped, kept as it is...
  unsupportedConfigOverrides:
    extendedArguments:
      resource-quota-sync-period:
      - 60s
Save and exit.

Tips about it:
From another repo https://github.com/openshift/cluster-kube-apiserver-operator :
"The configuration for the Kubernetes API server is the result of merging:
    a default config
    observed config (compare observed values above) spec.spec.unsupportedConfigOverrides from the kubeapiserveroperatorconfig"

Thus let's check https://github.com/openshift/cluster-kube-controller-manager-operator for "controllerArguments", will get its "default config": https://github.com/openshift/cluster-kube-controller-manager-operator/blob/master/bindata/v3.11.0/kube-controller-manager/defaultconfig.yaml , notice the "extendedArguments" part.

Then let's check `oc get kubecontrollermanager cluster -o yaml` to see which are "observed config"
...
spec:
...
  observedConfig: # Below are the "observed config"
    extendedArguments:
      cloud-provider:
      - aws
      cluster-cidr:
      - 10.128.0.0/14
      service-cluster-ip-range:
      - 172.30.0.0/16
    serviceServingCert:
      certFile: /etc/kubernetes/static-pod-resources/configmaps/service-ca/ca-bundle.crt
  unsupportedConfigOverrides: null
...

From above, we know resource-quota-sync-period is not under "observedConfig". Thus, it should be under "unsupportedConfigOverrides". Let's set it under "unsupportedConfigOverrides" by `oc edit kubecontrollermanager cluster`:
...snipped, kept as it is...
  unsupportedConfigOverrides:
    extendedArguments:
      resource-quota-sync-period:
      - 60s
Save and exit.

Verification of above steps:
After oc edit, check `oc get po -n openshift-kube-controller-manager`, the kube-controller-manager-... pods will be recreated. Wait until they're running, then check the log:
$ oc logs -n openshift-kube-controller-manager kube-controller-manager-ip-172-31-140-231.ec2.internal > kcm.log
$ grep resource-quota-sync-period kcm.log
I0409 10:02:20.843268       1 flags.go:33] FLAG: --resource-quota-sync-period="1m0s"
^ This means above steps take effect.

Hi @Xingxing,

For item 2 ("Configuring quota synchronization period"), I think I've updated the procedure appropriately, if you wouldn't mind taking a look at the preview here [1].

In what you listed for 1b, I didn't see master-restart for the "Requiring explicit quota to consume a resource" section, but I did remove it from the above "Configuring quota synchronization period" section, if that was the intention.

For item 1a, I don't see enough information in the linked doc to be able to determine what the right object is to edit, and the right YAML to use instead. Can you help me with the proper steps? 

Thanks!

[1] http://file.rdu.redhat.com/~ahoffer/2019/BZ-1684357/applications/quotas/quotas-setting-per-project.html#quotas-configuring-quota-sync-period-quotas-setting-per-project

Hi @Xingxing Xia, would you be able to take a look at the updates I made for item 2 (See the above comment). The WIP PR is here: https://github.com/openshift/openshift-docs/pull/14639. And just looking for some assistance with the correct steps for item 1a. Thanks!

For item 2, https://github.com/openshift/openshift-docs/pull/14639 LGTM
For 1b, maybe somebody did the removal of master-restart.
For 1a, there is Dev change of configuration steps I need to investigate next days.

Andrea, as to 1a, today I tried but didn't get a working 4.1 configuring way for "Requiring explicit quota to consume a resource". It is better to consult Pod or Master Dev directly.

Thanks @Xingxing Xia, I'll reach out. I'm going to go ahead and merge this PR so that item 2 is taken care of, and I will follow up with a separate PR for item 1 once we determine the updates needed.

Notes for assigning back: comment 12 was done by errata system. But per previous comment 9 - 11, item 1a still needs update for current new Target Release.

PR LGTM, thanks

Thanks! Moving to release pending.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:1382