Bug 1684589

Summary: [RFE] - Allow a '*' glob within a file path in a SmartState Analysis profile
Product: Red Hat CloudForms Management Engine Reporter: Peter McGowan <pmcgowan>
Component: SmartState AnalysisAssignee: Jerry Keselman <jkeselma>
Status: CLOSED ERRATA QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.0CC: akarol, bthurber, dmetzger, jkeselma, ldixon, miguel, mshriver, obarenbo, sbulage, simaishi
Target Milestone: GAKeywords: Reopened, RFE, ZStream
Target Release: 5.11.5Flags: pm-rhel: cfme-5.11.z+
mfeifer: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-05 13:43:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Feature
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1824259    
Bug Blocks:    

Description Peter McGowan 2019-03-01 15:31:04 UTC
Description of problem:
It would be useful to allow a '*' glob within a file path in a SmartState Analysis profile. Examples might be to collect the .bash_profile files of all users:

/home/*/.bash_profile

or to collect a WebSphere configuration regardless of which profile, cell or server was used at installation time:
 
/opt/IBM/WebSphere/AppServer/profiles/*/config/cells/*/nodes/*/servers/*/server.xml

Version-Release number of selected component (if applicable):
5.10.0.33

Expected results:


Additional info:

Comment 2 Lynn Dixon 2019-03-27 20:41:22 UTC
We are hitting this bug with a customer now.  Can't recursively dig into directories.

Comment 6 Jerry Keselman 2020-03-16 14:00:33 UTC
@Brett, working through the CodeClimate and RuboCop issues with the code.  Still need tests.  I will go on to the sizing issue following the current PR.

Comment 7 Jerry Keselman 2020-03-17 14:59:49 UTC
And as of today CodeClimate is resolved and working on migrating some of Rich's tests from the VirtFS gem.  There is one (minor) core PR that will need to be submitted as well in order to get the correct full filename in the DB.

Comment 8 Jerry Keselman 2020-03-18 16:39:52 UTC
PRs https://github.com/ManageIQ/manageiq-smartstate/pull/114
and https://github.com/ManageIQ/manageiq/pull/19976
address this RFE.  Awaiting reviews.

Comment 10 CFME Bot 2020-04-03 13:30:18 UTC
New commit detected on ManageIQ/manageiq/jansa:

https://github.com/ManageIQ/manageiq/commit/29c6aabb0816cd50eb087a731c1b85c3fdd5bd12
commit 29c6aabb0816cd50eb087a731c1b85c3fdd5bd12
Author:     Adam Grare <agrare>
AuthorDate: Fri Mar 27 19:22:39 2020 +0000
Commit:     Adam Grare <agrare>
CommitDate: Fri Mar 27 19:22:39 2020 +0000

    Merge pull request #19976 from jerryk55/expanded_glob_processing

    Fix Full Pathname Stored in DB

    (cherry picked from commit aea81a43c5e6f16e0c86d2cbcc8f7707b0ec634c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1684589

 app/models/filesystem.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 11 Satoe Imaishi 2020-04-03 13:51:54 UTC
https://github.com/ManageIQ/manageiq/pull/20025

Comment 12 CFME Bot 2020-04-03 13:55:17 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/4253e8d3f3c7779cd1b691c3f6642fe0ce7104c5
commit 4253e8d3f3c7779cd1b691c3f6642fe0ce7104c5
Author:     Adam Grare <agrare>
AuthorDate: Fri Mar 27 19:22:39 2020 +0000
Commit:     Adam Grare <agrare>
CommitDate: Fri Mar 27 19:22:39 2020 +0000

    Merge pull request #19976 from jerryk55/expanded_glob_processing

    Fix Full Pathname Stored in DB

    (cherry picked from commit aea81a43c5e6f16e0c86d2cbcc8f7707b0ec634c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1684589

 app/models/filesystem.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 16 Jerry Keselman 2020-04-16 17:38:10 UTC
https://github.com/ManageIQ/manageiq-smartstate/pull/121 addresses this problem.

Comment 20 errata-xmlrpc 2020-05-05 13:43:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2020