Bug 1685153

Summary: /etc/collectd.d/tendrl_gluster.conf file is changed only on provisioner node after update
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Filip Balák <fbalak>
Component: web-admin-tendrl-node-agentAssignee: gowtham <gshanmug>
Status: CLOSED CURRENTRELEASE QA Contact: sds-qe-bugs
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rhgs-3.4CC: rhs-bugs, sankarshan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-09 09:04:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Filip Balák 2019-03-04 14:02:51 UTC 
Description of problem:
If Tendrl is upgraded to 3.4.4 then /etc/collectd.d/tendrl_gluster.conf configuration files on gluster nodes should be updated. After update there should not be attribute `provisioner` and there should be added attribute `node_id` in tendrl_gluster.conf. This is done only on provisioner node but configuration on all other nodes remains the same.

Version-Release number of selected component (if applicable):
tendrl-ansible-1.6.3-11.el7rhgs.noarch
tendrl-api-1.6.3-13.el7rhgs.noarch
tendrl-api-httpd-1.6.3-13.el7rhgs.noarch
tendrl-commons-1.6.3-17.el7rhgs.noarch
tendrl-gluster-integration-1.6.3-15.el7rhgs.noarch
tendrl-grafana-plugins-1.6.3-21.el7rhgs.noarch
tendrl-grafana-selinux-1.5.4-3.el7rhgs.noarch
tendrl-monitoring-integration-1.6.3-21.el7rhgs.noarch
tendrl-node-agent-1.6.3-18.el7rhgs.noarch
tendrl-notifier-1.6.3-4.el7rhgs.noarch
tendrl-selinux-1.5.4-3.el7rhgs.noarch
tendrl-ui-1.6.3-15.el7rhgs.noarch


How reproducible:
90%

Steps to Reproduce:
I have discovered this bug during testing bz 1647910 so beginning of reproducer is the same.
1. Install Tendrl with 3.4.3 version.
2. Import gluster cluster.
3. Check /etc/collectd.d/tendrl_gluster.conf file on all nodes:
 # cat /etc/collectd.d/tendrl_gluster.conf
4. Stop tendrl-node-agent service on all nodes.
5. Wait for 300 seconds.
6. Start tendrl-node-agent service on all nodes.
7. Check /etc/collectd.d/tendrl_gluster.conf file on all nodes.
 There should be more nodes marked as provisioner.
8. Perform Tendrl upgrade to BU4 as described in documentation.
9. Check /etc/collectd.d/tendrl_gluster.conf file on all nodes.

Actual results:
One node that was previously marked as provisioner has updated collectd configuration but the rest of nodes have old configuration.

Expected results:
There should not be attribute `provisioner` in collectd configuration and there should be added attribute `node_id` in <Module "tendrl_gluster"> in /etc/collectd.d/tendrl_gluster.conf.

Additional info:
When I stop node-agent on provisioner node after update for 300 seconds then I see that in etcd it is not changed.