Bug 1685332

Summary:	Service catalog needs system-cluster-critical priority class
Product:	OpenShift Container Platform	Reporter:	Jessica Forrester <jforrest>
Component:	Service Catalog	Assignee:	Dan Geoffroy <dageoffr>
Status:	CLOSED ERRATA	QA Contact:	Jian Zhang <jiazha>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.1.0
Target Milestone:	---
Target Release:	4.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-04 10:45:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Jessica Forrester 2019-03-05 01:04:56 UTC

We need our platform components to set the system-cluster-critical priorityClassName on their workloads. More detail here:
https://github.com/openshift/origin/pull/22217

For service catalog this means updating the deployments that generate these pods:
openshift-svcat-apiserver-operator/openshift-svcat-apiserver-operator-586bd7dc64-vl2qt,
openshift-svcat-controller-manager-operator/openshift-svcat-controller-manager-operator-7f8fbc8fb4-8bwbx

Note: the test in the linked PR above runs on what is installed by default, so it is only flagging the svc catalog operators. But when service catalog is enabled we need to ensure the actual apiserver and controller manager pods are also running with system-cluster-critical priority class.

Comment 1 Jay Boyd 2019-03-06 13:16:59 UTC

fixed by https://github.com/openshift/cluster-svcat-apiserver-operator/pull/36 and https://github.com/openshift/cluster-svcat-controller-manager-operator/pull/23

Comment 3 Jian Zhang 2019-03-11 08:10:54 UTC

The current payload doesn't include the fixed PR, change status to MODIFIED.
Cluster version is 4.0.0-0.nightly-2019-03-06-074438

Comment 5 Jian Zhang 2019-03-14 08:25:40 UTC

LGTM, verify it.

Current version: 4.0.0-0.nightly-2019-03-13-233958

[jzhang@dhcp-140-18 ocp14]$ oc get pods -o yaml -n openshift-service-catalog-controller-manager-operator |grep priority
    priority: 2000000000
    priorityClassName: system-cluster-critical
[jzhang@dhcp-140-18 ocp14]$ oc get pods -o yaml -n openshift-service-catalog-apiserver-operator |grep priority
    priority: 2000000000
    priorityClassName: system-cluster-critical

[jzhang@dhcp-140-18 ocp14]$ oc get pods -o yaml -n openshift-service-catalog-apiserver  |grep priority
    priority: 2000000000
    priorityClassName: system-cluster-critical

[jzhang@dhcp-140-18 ocp14]$ oc get pods -o yaml -n openshift-service-catalog-controller-manager   |grep priority
    priority: 2000000000
    priorityClassName: system-cluster-critical

Comment 8 errata-xmlrpc 2019-06-04 10:45:04 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0758