Bug 1685783

Summary: neovim needs lua-lpeg-compat for lua 5.1
Product: [Fedora] Fedora Reporter: Aron Griffis <aron>
Component: lua-lpegAssignee: Tim Niemueller <tim>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, tim
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: lua-lpeg-1.0.1-9.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-29 19:12:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
lua-lpeg.compat.patch none

Description Aron Griffis 2019-03-06 03:54:16 UTC 
Description of problem:
neovim builds presently with lua 5.3 on Fedora, but upstream advises that it should use 5.1. This means that lua-lpeg needs to be built for 5.1 too.

Version-Release number of selected component (if applicable):
1.0.1-7

Steps to Reproduce:
1. try to build neovim with lua 5.1 or luajit

Actual results:
fails missing mpack

Expected results:
builds and runs like the wind

Additional info:
Also affects lua-mpack and neovim itself. I'll be submitting patches for all.
Comment 1 Aron Griffis 2019-03-06 03:55:30 UTC 
Created attachment 1541218 [details]
lua-lpeg.compat.patch
Comment 2 Aron Griffis 2019-03-06 04:00:17 UTC 
The patch mainly adds the compat build for Lua 5.1, but also fixes a build problem. The OPT variable which was set on the make command-line isn't effectively applied by the Makefile. Passing through CC instead works.
Comment 3 Fedora Update System 2019-03-11 19:09:24 UTC 
lua-lpeg-1.0.1-9.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a08739b2fa
Comment 4 Fedora Update System 2019-03-12 16:08:48 UTC 
lua-lpeg-1.0.1-9.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a08739b2fa
Comment 5 Fedora Update System 2019-03-29 19:12:02 UTC 
lua-lpeg-1.0.1-9.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.