Bug 1686210

Summary:	Review Request: perl-JSON-Validator - Validate data against a JSON schema
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-07 19:59:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2019-03-06 23:01:57 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-JSON-Validator/perl-JSON-Validator.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-JSON-Validator/perl-JSON-Validator-3.06-1.fc29.src.rpm
Description:
JSON::Validator is a data structure validation library based around JSON
Schema. This module can be used directly with a JSON schema or you can use
the elegant DSL schema-builder JSON::Validator::joi to define the schema
programmatically.

Fedora Account System Username: eseyman
Rpmlint Errors:
perl-JSON-Validator.src: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 1 Jitka Plesnikova 2019-03-07 15:48:01 UTC

Source file is ok
Summary is ok
License is ok
Description is ok

URL and Source0
FIX: Please update URL and source0 to the new location:
     URL: https://metacpan.org/release/JSON-Validator
     Source0: https://cpan.metacpan.org/authors/id/J/JH/JHTHORSEN/JSON-Validator-%{version}.tar.gz

All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-JSON-Validator-3.06-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(B)
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Exporter)
      1 perl(JSON::Validator)
      1 perl(JSON::Validator::Error)
      1 perl(JSON::Validator::Formats)
      1 perl(JSON::Validator::Joi)
      1 perl(JSON::Validator::Ref)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Mojo::Base)
      1 perl(Mojo::File)
      1 perl(Mojo::JSON)
      1 perl(Mojo::JSON::Pointer)
      1 perl(Mojolicious) >= 7.28
      1 perl(Mojo::Loader)
      1 perl(Mojo::URL)
      1 perl(Mojo::Util)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(Tie::Hash)
      1 perl(Tie::StdHash)
      1 perl(Time::Local)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
All mandatory run-requires are listed.

TODO: Please consider adding following optional dependencies as Suggests:
      YAML::XS 0.67
      Term::ANSIColor
      Mojo::UserAgent
      Data::Validate::Domain
      Data::Validate::IP
      Net::IDN::Encode

$ rpm -qp --provides perl-JSON-Validator-3.06-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(JSON::Validator) = 3.06
      1 perl-JSON-Validator = 3.06-1.fc30
      1 perl(JSON::Validator::Error)
      1 perl(JSON::Validator::Formats)
      1 perl(JSON::Validator::Joi)
      1 perl(JSON::Validator::Ref)
Binary provides are Ok.

$ rpmlint ./perl-JSON-Validator*
perl-JSON-Validator.noarch: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally
perl-JSON-Validator.src: W: spelling-error %description -l en_US programmatically -> pro grammatically, pro-grammatically, programmatic ally
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct all 'FIX' issues and consider fixing 'TODO' items.

Otherwise, the package looks good.
Approved.

Comment 2 Gwyn Ciesla 2019-03-07 19:09:53 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-JSON-Validator

Comment 3 Emmanuel Seyman 2019-03-07 19:59:49 UTC

JFTR, I took into account all your comments before building for rawhide and publishing updates for f30 and f29.

Thank you for the review, Jikta.