Bug 1686225
| Summary: | Remove the deprecated "Discover Cloud Providers" option from CloudForms UI | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Nikhil Gupta <ngupta> | |
| Component: | UI - OPS | Assignee: | Greg Piatigorski <gpiatigo> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Parthvi Vala <pvala> | |
| Severity: | low | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | |
| Priority: | low | |||
| Version: | 5.10.1 | CC: | bmidwood, dmetzger, gpiatigo, hkataria, jprause, lavenel, mpovolny, mshriver, obarenbo | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.11.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.11.0.1 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1695626 (view as bug list) | Environment: | ||
| Last Closed: | 2019-12-13 15:08:43 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | Feature | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | CFME Core | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1692488, 1695626 | |||
|
Description
Nikhil Gupta
2019-03-07 01:06:31 UTC
Yes, testing code removal and should be creating the PR later tonight or tomorrow. Just want to make sure I do not break anything. It will be multi-PR since both base ad UI sides have changes. Code refactoring requires code refactoring for both base and classic UI branches. In the base branch one needs to run MiqShortcut.seed as part of testing/implementation. Classic UI: https://github.com/ManageIQ/manageiq-ui-classic/pull/5395 Base branch PR: https://github.com/ManageIQ/manageiq/pull/18607 New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/b1ecb04ca1d2bf1be63ab75c55a731f44e146b81 commit b1ecb04ca1d2bf1be63ab75c55a731f44e146b81 Author: Greg Piatigorski <gpiatigo> AuthorDate: Thu Mar 28 16:31:03 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Thu Mar 28 16:31:03 2019 -0400 Remove Discover Cloud Providers option in toolbar drop-down https://bugzilla.redhat.com/show_bug.cgi?id=1686225 db/fixtures/miq_product_features.yml | 4 - locale/manageiq.pot | 5 - 2 files changed, 9 deletions(-) New commits detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/954ba4738e49411141574f7eab29a5f6df7ff4c9 commit 954ba4738e49411141574f7eab29a5f6df7ff4c9 Author: Greg Piatigorski <gpiatigo> AuthorDate: Thu Mar 28 16:07:37 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Thu Mar 28 16:07:37 2019 -0400 Remove deprecated Discover Cloud Providers drop-down selection https://bugzilla.redhat.com/show_bug.cgi?id=1686225 app/controllers/mixins/actions/host_actions/discover.rb | 15 +- app/helpers/application_helper/toolbar/ems_clouds_center.rb | 8 - locale/ManageIQ_UI_Classic.pot | 4 - spec/controllers/ems_cloud_controller_spec.rb | 6 - 4 files changed, 2 insertions(+), 31 deletions(-) https://github.com/ManageIQ/manageiq-ui-classic/commit/57b0d056b24afa343d215405c03a9b0829826e70 commit 57b0d056b24afa343d215405c03a9b0829826e70 Author: Greg Piatigorski <gpiatigo> AuthorDate: Mon Apr 1 15:34:52 2019 -0400 Commit: Greg Piatigorski <gpiatigo> CommitDate: Mon Apr 1 15:34:52 2019 -0400 Remove deprecated Discover Cloud Providers Additional cleanup to remove all remnants of ems_cloud reference/checks https://bugzilla.redhat.com/show_bug.cgi?id=1686225 app/controllers/mixins/actions/host_actions/discover.rb | 61 +- spec/controllers/application_controller/ci_processing_spec.rb | 15 - 2 files changed, 16 insertions(+), 60 deletions(-) FIXED. Verified on 5.11.0.2.20190430174828_0e34dea. |