Bug 1686548

Summary: Incorrect handling of fragmented KeyUpdate messages
Product: Red Hat Enterprise Linux 8 Reporter: Alicja Kario <hkario>
Component: opensslAssignee: Tomas Mraz <tmraz>
Status: CLOSED ERRATA QA Contact: Daiki Ueno <dueno>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.0CC: dueno
Target Milestone: rcKeywords: Triaged
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openssl-1.1.1b-3.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-05 22:40:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1643026, 1682501    
Bug Blocks:    

Description Alicja Kario 2019-03-07 16:43:24 UTC
Description of problem:
When OpenSSL receives fragmented KeyUpdate message with application data in-between, it does not reject the connection. This is a RFC 8446 section 5.1 violation:

   -  Handshake messages MUST NOT be interleaved with other record
      types.  That is, if a handshake message is split over two or more
      records, there MUST NOT be any other records between them.


Version-Release number of selected component (if applicable):
openssl-1.1.1-8.el8.x86_64

How reproducible:
always

Steps to Reproduce:
1. run tlsfuzzer test-tls13-keyupdate.py against openssl server

Actual results:
failed cases include
  '1/4 fragmented keyupdate msg, appdata between'
  '2/3 fragmented keyupdate msg, appdata between'
  '3/2 fragmented keyupdate msg, appdata between'

Expected results:
above mentioned tests pass

Additional info:
There are also two unrelated failures:
'app data split, conversation with KeyUpdate msg'
caused by https://github.com/openssl/openssl/issues/8188
'large KeyUpdate message'
caused by https://github.com/openssl/openssl/issues/8189 and https://github.com/openssl/openssl/issues/8293

Comment 4 Daiki Ueno 2019-07-04 11:24:48 UTC
Created attachment 1587363 [details]
test log

Successfully verified with openssl-1.1.1c-1.el8.x86_64.

Comment 6 errata-xmlrpc 2019-11-05 22:40:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3700