Bug 1686561

Summary:	vmi goes to zombie after changing label nodename
Product:	Container Native Virtualization (CNV)	Reporter:	Asher Shoshan <ashoshan>
Component:	Virtualization	Assignee:	Daniel Belenky <dbelenky>
Status:	CLOSED ERRATA	QA Contact:	vsibirsk
Severity:	medium	Docs Contact:
Priority:	medium
Version:	1.4	CC:	cnv-qe-bugs, dbelenky, fdeutsch, ipinto, ncredi, rmohr, sgordon, sgott
Target Milestone:	---
Target Release:	2.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	hyperconverged-cluster-operator-container-v2.2.0-3 virt-operator-container-v2.2.0-2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-01-30 16:27:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Asher Shoshan 2019-03-07 17:18:50 UTC

Description of problem:

vmi is not responsive after label change

Version-Release number of selected component (if applicable):


How reproducible:

Steps to Reproduce:
1. oc edit vmi xxx
2. change label "kubevirt.io/nodeName" value to some other valid value
3. save (wq)

Actual results:

virtctl console/start/stop not responsive

Expected results:

Move vmi to the new node?

Additional info:

It can be recovered after re-edit with the original value

Comment 1 Tomas Jelinek 2019-03-07 17:42:12 UTC

This is probably virt.

Comment 2 Fabian Deutsch 2019-03-18 10:07:13 UTC

As it stands right now, we need to block to edit the label.

The reason the label is required is that we ca not watch by fields of CRs, that's why we have the label to find CRS for a given node. This is used by handler.

Comment 3 Daniel Belenky 2019-03-21 13:10:52 UTC

PR sent (upstream) https://github.com/kubevirt/kubevirt/pull/2136/
and is under review

Comment 7 Daniel Belenky 2019-09-04 13:36:14 UTC

https://www.google.com/url?q=https://github.com/kubevirt/kubevirt/pull/2136 is a workaround for this issue - users are no longer able to modify kubevirt internal labels.

Comment 8 vsibirsk 2019-12-22 15:03:35 UTC

verified on:

oc version
Client Version: v4.2.5
Server Version: 4.3.0-0.nightly-2019-12-19-050538
Kubernetes Version: v1.16.2

oc get csv -n openshift-cnv
NAME                                      DISPLAY                                    VERSION   REPLACES                                  PHASE
kubevirt-hyperconverged-operator.v2.2.0   Container-native virtualization Operator   2.2.0     kubevirt-hyperconverged-operator.v2.1.0   Succeeded

following steps:
1. oc edit vmi xxx
2. change label "kubevirt.io/nodeName" value to some other valid value
3. save (wq)
getting error message when trying to save.

Comment 10 errata-xmlrpc 2020-01-30 16:27:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:0307