Bug 1686572

Summary:	In metrics-store-installation role need to get update the way we get the engine ssh public key
Product:	[oVirt] ovirt-engine-metrics	Reporter:	Shirly Radco <sradco>
Component:	Generic	Assignee:	Shirly Radco <sradco>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ivana Saranova <isaranov>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	bugs, lleistne
Target Milestone:	ovirt-4.3.5	Flags:	sradco: ovirt-4.3? sbonazzo: devel_ack+ lleistne: testing_ack+
Target Release:	1.3.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-metrics-1.3.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-30 14:08:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1715513
Bug Blocks:	1710361

Description Shirly Radco 2019-03-07 17:49:28 UTC

Description of problem:
In metrics-store-installation role need to get update the way we get the engine ssh public key. We currently generate it from etc/pki/ovirt-engine/keys/engine_id_rsa and we delete the file at the end of the role.
Need to check if there is a better way to do that.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.Run that the metrics-store-installation role
2. See that the ssh_key is being generated correctly in the vas.yml file that is generated from a template and saved to /usr/share/ansible/roles/oVirt.openshift-ovirt/vars.yml 
3.

Actual results:


Expected results:


Additional info:

Comment 1 Shirly Radco 2019-05-15 09:18:30 UTC

After discussing this with Didi, the only fix was removing an unneeded step for copying the engine_id_rsa.
Please test using the steps to reproduce to check that there is no regression.

Comment 2 Ivana Saranova 2019-05-30 14:34:08 UTC

Cannot verify due to this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1715513

Comment 3 Ivana Saranova 2019-06-26 11:15:50 UTC

Steps:
1.Run that the metrics-store-installation role
2. See that the ssh_key is being generated correctly in the vas.yml file that is generated from a template and saved to /usr/share/ansible/roles/oVirt.openshift-ovirt/vars.yml 

Result:
SSH key is generated and saved in the vars.yml file. Installation ends with success.

Verified in:
ovirt-engine-metrics-1.3.2-1.el7ev.noarch
ovirt-engine-4.3.4.3-0.1.el7.noarch

Comment 4 Sandro Bonazzola 2019-07-30 14:08:25 UTC

This bugzilla is included in oVirt 4.3.5 release, published on July 30th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.