Bug 1686645

Summary: Remove empty else block.
Product: Red Hat Enterprise Linux 8 Reporter: Ryan Blakley <rblakley>
Component: libdnfAssignee: Packaging Maintenance Team <packaging-team-maint>
Status: CLOSED ERRATA QA Contact: Radek Bíba <rbiba>
Severity: low Docs Contact:
Priority: low    
Version: 8.0CC: dmach, emrakova, jmracek
Target Milestone: rcKeywords: Triaged
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libdnf-0.33.0-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-05 22:21:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1679648    
Bug Blocks:    

Description Ryan Blakley 2019-03-07 23:08:37 UTC 
Description of problem: While looking into another issue I noticed an empty else block. I don't think it will cause any issues per se, just figured I'd report it. I found the upstream commit that removes it, and linked it below.

** libdnf/utils/sqlite3/Sqlite3.cpp
 48 void
 49 SQLite3::close()
 50 {
 51     if (db == nullptr)
 52         return;
 53     auto result = sqlite3_close(db);
 54     if (result == SQLITE_BUSY) {
 55         sqlite3_stmt *res;
 56         while ((res = sqlite3_next_stmt(db, nullptr))) {
 57             sqlite3_finalize(res);
 58         }
 59         result = sqlite3_close(db);
 60     } else { <<<<<<<
 61     }
 62     if (result != SQLITE_OK) {
 63         throw LibException(result, "Close failed");
 64     }
 65     db = nullptr;
 66 }

Additional info: Upstream commit https://github.com/rpm-software-management/libdnf/commit/e5e652b6b207ac9ec48f8a5ca0882a6bde1c3806#diff-c7365e2d69b533523f7f6442fa23a0d9
Comment 5 errata-xmlrpc 2019-11-05 22:21:30 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3583