Bug 1686668

Description of problem:
After removing and adding operators from a custom app registry and forcing a resync, installing a new operator results in the installation CSC getting stuck in the "Configuring" phase with the message "Still resolving package(s) - . Please make sure these are valid packages."

Version-Release number of selected component (if applicable):
ClusterVersion: quay.io/openshift-release-dev/ocp-release@sha256:641c0e4f550af59ec20349187a31751ae5108270f13332d1771935520ebf34c1
Installer version: 0.14.0

How reproducible:


Steps to Reproduce:
1. Create a namespace on quay, and add at least one Application to it with an operator bundle. This can be done with the `operator-courier push` command as outlined here: https://github.com/operator-framework/operator-courier

Be sure to note the supported installMode for this operator. I used an AllNamespace operator.

2. Add a custom OperatorSource CR to the openshift-marketplace namespace pointing to your quay namespace:

apiVersion: marketplace.redhat.com/v1alpha1
kind: OperatorSource
metadata:
  name: custom-operators
  namespace: openshift-marketplace
spec:
  displayName: Custom Operators
  endpoint: https://quay.io/cnr
  publisher: Red Hat
  registryNamespace: <YOUR_QUAY_NAMESPACE>
  type: appregistry

3. Install the operator via the OpenShift console UI.

4. After the operator is fully installed (subscription should say "Up to date" under "Operator Management" in the "Operator Subscriptions" tab) delete the Application from quay (click on the application and go to "Settings", at the bottom of the page there should be a red "Delete Application" button).

5. Upload a different operator to the quay namespace. The name should be different from the original. Also, the new operator must support the same installModes as the previous one. In my case it was AllNamespaces.

6. Delete and reapply the OperatorSource to force a resync.

7. From the OperatorHub UI, install the new operator that was pushed to quay.

8. Under "Operator Management" in the "Operator Subscriptions" tab, remove the subscription for the OLD operator. Make sure the checkbox is checked.

9. From the CLI, run:

$ oc get csc -n openshift-marketplace installed-custom-openshift-operators -o yaml

The "openshift-operators" part of the CSC name comes from the installed namespace. If using an AllNamespace install operator it should match the command provided.

Actual results:

$ oc get csc -n openshift-marketplace installed-custom-openshift-operators -o yaml
apiVersion: marketplace.redhat.com/v1alpha1
kind: CatalogSourceConfig
metadata:
  creationTimestamp: 2019-03-07T20:05:35Z
  finalizers:
  - finalizer.catalogsourceconfigs.marketplace.redhat.com
  generation: 1
  name: installed-custom-openshift-operators
  namespace: openshift-marketplace
  resourceVersion: "1036062"
  selfLink: /apis/marketplace.redhat.com/v1alpha1/namespaces/openshift-marketplace/catalogsourceconfigs/installed-custom-openshift-operators
  uid: 5e6e3cb5-4114-11e9-b9f9-0a13676e199a
spec:
  csDisplayName: Custom Operators
  csPublisher: Custom
  packages: ',strimzi-kafka-operator-test'
  targetNamespace: openshift-operators
status:
  currentPhase:
    lastTransitionTime: 2019-03-08T00:21:18Z
    lastUpdateTime: 2019-03-08T00:21:18Z
    phase:
      message: Still resolving package(s) - . Please make sure these are valid packages.
      name: Configuring

The CSC is stuck in the Configuring phase. Notice the `spec.packages` string has a leading comma before the operator's name (which is the second operator installed).

Expected results:
$ oc get csc -n openshift-marketplace installed-custom-openshift-operators -o yaml
apiVersion: marketplace.redhat.com/v1alpha1
kind: CatalogSourceConfig
metadata:
  creationTimestamp: 2019-03-08T00:26:30Z
  finalizers:
  - finalizer.catalogsourceconfigs.marketplace.redhat.com
  generation: 1
  name: installed-custom-openshift-operators
  namespace: openshift-marketplace
  resourceVersion: "1039455"
  selfLink: /apis/marketplace.redhat.com/v1alpha1/namespaces/openshift-marketplace/catalogsourceconfigs/installed-custom-openshift-operators
  uid: d1ef5829-4138-11e9-89b8-0297441e13f2
spec:
  csDisplayName: Custom Operators
  csPublisher: Custom
  packages: strimzi-kafka-operator-test
  targetNamespace: openshift-operators
status:
  currentPhase:
    lastTransitionTime: 2019-03-08T00:26:30Z
    lastUpdateTime: 2019-03-08T00:26:30Z
    phase:
      message: The object has been successfully reconciled
      name: Succeeded

The CSC succeeds.

Additional info: