Bug 1687287 (rust-notify)

Summary: Review Request: rust-notify - Cross-platform filesystem notification library
Product: [Fedora] Fedora Reporter: Igor Raits <igor.raits>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-13 10:13:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Igor Raits 2019-03-11 08:16:09 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-notify.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-notify-4.0.10-1.fc31.src.rpm
Description:
Cross-platform filesystem notification library.
Fedora Account System Username: ignatenkobrain

Comment 1 Robert-André Mauchin 🐧 2019-03-12 03:06:53 UTC
 - License ok
 - Latest version packaged

Test failure:

failures:
---- create_directory_watch_subdirectories stdout ----
thread 'create_directory_watch_subdirectories' panicked at 'assertion failed: `(left == right)`
  left: `[("/tmp/temp_dir.BpkuB7S8KNQg/dir1", CREATE, None), ("/tmp/temp_dir.BpkuB7S8KNQg/dir1/dir2", CREATE, None), ("/tmp/temp_dir.BpkuB7S8KNQg/dir1/dir2/file1", CREATE, None), ("/tmp/temp_dir.BpkuB7S8KNQg/dir1/dir2/file1", CLOSE_WRITE, None)]`,
 right: `[("/tmp/temp_dir.BpkuB7S8KNQg/dir1", CREATE, None), ("/tmp/temp_dir.BpkuB7S8KNQg/dir1/dir2/file1", CREATE, None), ("/tmp/temp_dir.BpkuB7S8KNQg/dir1/dir2/file1", CLOSE_WRITE, None)]`', tests/notify.rs:507:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
failures:
    create_directory_watch_subdirectories
test result: FAILED. 18 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

Comment 3 Igor Raits 2019-03-13 00:06:48 UTC
I've reported to upstream and disabled tests for now (we do that anyway because we run them in Fedora CI).

Comment 4 Robert-André Mauchin 🐧 2019-03-13 03:30:36 UTC
Ok package approved.

Comment 5 Igor Raits 2019-03-13 09:27:19 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-notify