Bug 1687300

Summary:	[OSP13] Fix VF-rep lookup routine to use parent PF number
Product:	Red Hat OpenStack	Reporter:	Bertrand <brault>
Component:	openstack-nova	Assignee:	OSP DFG:Compute <osp-dfg-compute>
Status:	CLOSED CURRENTRELEASE	QA Contact:	OSP DFG:Compute <osp-dfg-compute>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	13.0 (Queens)	CC:	dasmith, eglynn, jhakimra, kchamart, nova-maint, sbauza, sgordon, skramaja, stephenfin, vromanso
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://github.com/openstack/os-vif/commit/84688a22db22039f5566c1439c3983db23672a45
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1687298	Environment:
Last Closed:	2019-03-15 15:19:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1687298
Bug Blocks:	1653846, 1686758, 1686772

Description Bertrand 2019-03-11 08:50:04 UTC

+++ This bug was initially created as a clone of Bug #1687298 +++

Fix VF-rep lookup routine to use parent PF number

The current logic in get_representor_port() matches the VF number with
the one in 'phys_port_name' file. If and when multiple PFs on the same
card are configured in switchdev mode, we could end up returning a wrong
representor device. Fix this by including the parent PF number also in
this logic, when 'pfXvfY' (or vfY@pfX) format is used in 'phys_port_name'
file.

github: https://github.com/openstack/os-vif/commit/84688a22db22039f5566c1439c3983db23672a45

This patch appear to be missing from nova-compute container in Queen / OSP 13

Comment 1 Bertrand 2019-03-11 08:55:54 UTC

Patch is tagged in os-vif 1.10 and above and nova requirements for queens is min os-vif 1.7 [1].


[1] https://github.com/openstack/nova/blob/stable/queens/requirements.txt#L57

Comment 3 Stephen Finucane 2019-03-15 15:17:48 UTC

This was resolved in python-os-vif-1.9.1-2, which is included in the latest container version, 13.0-81 [1], which was released yesterday. Apologies for the delay in releasing this.

[1] https://access.redhat.com/containers/?tab=package-list#/registry.access.redhat.com/rhosp13/openstack-nova-compute/images/13.0-81