Bug 1687450

Summary:	Review Request: perl-FFI-Platypus - Write Perl bindings to non-Perl libraries with FFI
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-FFI-Platypus-0.86-1.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-12 14:31:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-03-11 13:54:29 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-FFI-Platypus/perl-FFI-Platypus.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-FFI-Platypus/perl-FFI-Platypus-0.86-1.fc31.src.rpm
Description:
Platypus is a Perl library for creating interfaces to machine code libraries
written in languages like C, C++, Fortran, Rust, Pascal. Essentially anything
that gets compiled into machine code. This implementation uses libffi to
accomplish this task. libffi is battle tested by a number of other scripting
and virtual machine languages, such as Python and Ruby to serve a similar
role. There are a number of reasons why you might want to write an extension
with Platypus instead of XS.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-12 10:13:04 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-FFI-Platypus-0.86-1.fc31.x86_64.rpm | sort | uniq -c | grep -v 'FFI::\(Build\|Platypus\|Probe\)'
      1 gcc
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libdl.so.2()(64bit)
      1 libdl.so.2(GLIBC_2.2.5)(64bit)
      1 libffi.so.6()(64bit)
      1 libperl.so.5.28()(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(base)
      1 perl(bytes)
      1 perl(Capture::Tiny)
      1 perl(Carp)
      1 perl(Config)
      1 perl(constant) >= 1.32
      1 perl(Data::Dumper)
      1 perl(Exporter)
      1 perl(ExtUtils::MakeMaker) >= 7.12
      1 perl(FFI::CheckLib) >= 0.05
      1 perl(File::Basename)
      1 perl(File::Copy)
      1 perl(File::Glob)
      1 perl(File::Path)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(IPC::Cmd)
      1 perl(JSON::PP)
      1 perl(List::Util) >= 1.45
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Text::ParseWords)
      1 perl(:VERSION) >= 5.8.1
      1 perl(warnings)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-FFI-Platypus-0.86-1.fc31.x86_64.rpm | sort | uniq -c
      1 perl(FFI::Build) = 0.86
      1 perl(FFI::Build::File::Base) = 0.86
      1 perl(FFI::Build::File::C) = 0.86
      1 perl(FFI::Build::File::CXX) = 0.86
      1 perl(FFI::Build::File::Library) = 0.86
      1 perl(FFI::Build::File::Object) = 0.86
      1 perl(FFI::Build::MM) = 0.86
      1 perl(FFI::Build::MM::FBX)
      1 perl(FFI::Build::Platform) = 0.86
      1 perl(FFI::Platypus) = 0.86
      1 perl-FFI-Platypus = 0.86-1.fc31
      1 perl(FFI::Platypus::API) = 0.86
      1 perl(FFI::Platypus::Buffer) = 0.86
      1 perl(FFI::Platypus::Closure) = 0.86
      1 perl(FFI::Platypus::ClosureData) = 0.86
      1 perl(FFI::Platypus::Declare) = 0.86
      1 perl(FFI::Platypus::DL) = 0.86
      1 perl(FFI::Platypus::Function) = 0.86
      1 perl(FFI::Platypus::Function::Function)
      1 perl(FFI::Platypus::Function::Wrapper)
      1 perl(FFI::Platypus::Internal) = 0.86
      1 perl(FFI::Platypus::Lang) = 0.86
      1 perl(FFI::Platypus::Lang::ASM) = 0.86
      1 perl(FFI::Platypus::Lang::C) = 0.86
      1 perl(FFI::Platypus::Lang::Win32) = 0.86
      1 perl(FFI::Platypus::Memory) = 0.86
      1 perl(FFI::Platypus::Record) = 0.86
      1 perl(FFI::Platypus::Record::TieArray) = 0.86
      1 perl(FFI::Platypus::ShareConfig) = 0.86
      1 perl(FFI::Platypus::Type) = 0.86
      1 perl(FFI::Platypus::Type::PointerSizeBuffer) = 0.86
      1 perl(FFI::Platypus::Type::StringArray) = 0.86
      1 perl(FFI::Platypus::Type::StringPointer) = 0.86
      1 perl-FFI-Platypus(x86-64) = 0.86-1.fc31
      1 perl(FFI::Probe) = 0.86
      1 perl(FFI::Probe::Runner) = 0.86
      1 perl(FFI::Probe::Runner::Builder) = 0.86
      1 perl(FFI::Probe::Runner::Result) = 0.86
Binary provides are Ok.

$ rpmlint ./perl-FFI-Platypus*
perl-FFI-Platypus.src: W: spelling-error %description -l en_US libffi -> bailiff
perl-FFI-Platypus.x86_64: W: spelling-error %description -l en_US libffi -> bailiff
perl-FFI-Platypus.x86_64: W: no-soname /usr/lib64/perl5/vendor_perl/auto/share/dist/FFI-Platypus/lib/libplfill.so
perl-FFI-Platypus.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/auto/share/dist/FFI-Platypus/probe/src/dlrun.c
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok


The package looks good. 
Approved

Comment 2 Gwyn Ciesla 2019-03-12 13:46:35 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-FFI-Platypus

Comment 3 Petr Pisar 2019-03-12 14:31:27 UTC

Thank you for the review and the repository. I also packaged the examples.