Bug 1687574

Summary: zsh-5.7.1-1.fc30.src.rpm FTBFS
Product: [Fedora] Fedora Reporter: Philippe Troin <phil>
Component: zshAssignee: Kamil Dudka <kdudka>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dmaphy, james.antill, j, kdudka, svashisht
Target Milestone: ---Keywords: EasyFix
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: zsh-5.7.1-3.fc31 zsh-5.7.1-4.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-12 09:00:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Mock's installed_pkgs.log for a successful rawhide build of zsh none

Description Philippe Troin 2019-03-11 19:03:21 UTC
Description of problem:
zsh-5.7.1-1.fc30.src.rpm fails to build from source.

Version-Release number of selected component (if applicable):
zsh-5.7.1-1.fc30

How reproducible:
Always

Steps to Reproduce:
1. dnf download --enablerepo=rawhide --source zsh
2. rpmbuild --rebuild zsh-5.7.1-1.fc30.src.rpm

Actual results:
The build fails with:
hashnameddir.c:49:12: fatal error: rpc/types.h: No such file or directory
 #  include <rpc/types.h>
            ^~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makemod:230: hashnameddir.o] Error 1

Expected results:
The build should complete successfully.

Additional info:
Adding CPPFLAGS=-I/usr/include/tirpc seems to help.

Comment 1 Jason Tibbitts 2019-03-11 20:22:59 UTC
I cannot reproduce this.  The existing package builds quite fine in mock for me (on both F30 and rawhide), and in our buildsystem (https://koji.fedoraproject.org/koji/packageinfo?packageID=251) and in the package CI system (https://apps.fedoraproject.org/koschei/package/zsh).  I suspect that the issue falls with the environment in which you are building, as the clean environment provided by mock is fine.

Note that in general you cannot expect to do a local build of a random source package and have it simply work.  It works most of the time, but not all of the time.  One major issue is that configure scripts may detect extra things you have installed on your system and cause the build to differ in various ways.  Another possibility is that something in the default mock buildroot isn't installed on your local machine, though this is rarer and usually results in different breakage.  (Lack of redhat-rpm-config is one such package, but I don't think that's the case here.)

I can't really guess at what extra thing you might have which causes problems.  I'll attach the installed_packages.log file from a mock build.  If it's known what package causes an issue, it may be possible to work around it or, well, I've been told that BuildConflicts: exists.

Comment 2 Jason Tibbitts 2019-03-11 20:24:01 UTC
Created attachment 1543042 [details]
Mock's installed_pkgs.log for a successful rawhide build of zsh

Comment 3 Kamil Dudka 2019-03-12 08:54:56 UTC
It fails only if you have ypcat and valid NIS configuration.

Comment 4 Kamil Dudka 2019-03-12 09:00:02 UTC
downstream commit:

https://src.fedoraproject.org/cgit/rpms/zsh.git/commit/?id=711462cd

Comment 5 Fedora Update System 2019-07-26 17:09:41 UTC
FEDORA-2019-949a7cdde2 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-949a7cdde2

Comment 6 Fedora Update System 2019-07-27 01:22:31 UTC
zsh-5.7.1-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-949a7cdde2

Comment 7 Fedora Update System 2019-08-04 01:13:35 UTC
zsh-5.7.1-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.