Bug 1687937

Summary: Auto default wired connections should not be created if a custom one was already defined
Product: Red Hat Enterprise Linux 8 Reporter: Edward Haas <edwardh>
Component: NetworkManagerAssignee: Thomas Haller <thaller>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.3CC: atragler, bgalvani, fgiudici, lrintel, pasik, rkhan, sukulkar, thaller, till, vbenes
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-1.25.1-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 01:48:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
eth1-profile-is-auto-created none

Description Edward Haas 2019-03-12 17:11:37 UTC 
Description of problem:
Auto default wired connection are usually created on managed devices when no other profile has even been configured before.
If a connection has been defined by the user, in most scenarios, even when that custom profile is deleted, the auto default connection will not be created.
However, in cases where the device is in `unavailable` or `disconnected` state, it will be created.

This behaviour is not consistent and causes unintentional configuration to be applied on a device when the user actually wanted to delete/deactivate.

Ref:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/src/nm-manager.c?id=b10a7e5786e9c6bb95bd014ee165b452c247da6d#n1474

Version-Release number of selected component (if applicable):


How reproducible:
30%

Steps to Reproduce:
It has been reproduced periodically through the nmstate integration tests.
1. Delete an active profile.
2. The default profile is auto generated.

Actual results:
The default profile is auto generated.

Expected results:
The default profile should no be auto generated.

Additional info:
Comment 2 Edward Haas 2019-03-12 17:13:41 UTC 
Created attachment 1543298 [details]
eth1-profile-is-auto-created
Comment 4 Thomas Haller 2020-03-25 15:09:30 UTC 
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/450
Comment 5 Thomas Haller 2020-03-28 10:03:38 UTC 
fixed on master https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/ff814923ebfa434ba0ffaa13f0d61a4bb8ad6ec4
Comment 9 Vladimir Benes 2020-06-22 16:09:48 UTC 
could you give me some reproducer?

I am a bit lost in how to make difference between 1.22 and 1.26.

I have no connection for eth8, I don't have NM-config-server installed

systemctl restart NetworkManager
nmcli connection delete id Wired\ connection\ 1
rm -rf /var/lib/NetworkManager/no-auto-default.state

nmcli con add type ethernet ifname eth8 con-name con_general
nmcli con up con_general
sleep 1
nmcli con down con_general
sleep 1
nmcli device set eth8 managed no
nmcli device set eth8 managed yes
sleep 2
nmcli con del con_general
sleep 1
nmcli con
Comment 10 Thomas Haller 2020-06-22 17:06:59 UTC 
(In reply to Vladimir Benes from comment #9)
> could you give me some reproducer?

resolved via IRC (isn't that right?)
Comment 11 Vladimir Benes 2020-06-23 08:04:16 UTC 
(In reply to Thomas Haller from comment #10)
> (In reply to Vladimir Benes from comment #9)
> > could you give me some reproducer?
> 
> resolved via IRC (isn't that right?)

yes yes, test added:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/585
Comment 14 errata-xmlrpc 2020-11-04 01:48:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (NetworkManager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4499