Bug 1687953

Summary:	Review Request: libmanette - Game controller library
Product:	[Fedora] Fedora	Reporter:	Kalev Lember <klember>
Component:	Package Review	Assignee:	Pete Walter <walter.pete>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, pemensik, walter.pete
Target Milestone:	---	Flags:	walter.pete: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	libmanette-0.2.2-1.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-13 19:32:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kalev Lember 2019-03-12 18:21:15 UTC

Spec URL: https://kalev.fedorapeople.org/libmanette.spec
SRPM URL: https://kalev.fedorapeople.org/libmanette-0.2.2-1.fc30.src.rpm
Description:
libmanette is a small GObject library giving you simple access to game
controllers.

This library is intended for software needing a painless access to game
controllers from any programming language and with little dependencies.

It supports the de-facto standard gamepads as defined by the W3C standard
Gamepad specification or as implemented by the SDL GameController. More game
controller kinds could be supported in the future if needed. Mapping of the
devices is handled transparently and internally by the library using the
popular SDL mapping string format.

Fedora Account System Username: kalev

Comment 1 Petr Menšík 2019-03-13 10:43:15 UTC

Spec seems nice and tidy. My local build was successful. However fedpkg mockbuild fails, as well as master scratch build from your sources [1].
Could you take a look on it? It seems something in not correct in meson build.

Fails on:
/usr/bin/ld: src/25a6634@@manette-0.2@sha/meson-generated_.._manette_resources.c.o:/builddir/build/BUILD/libmanette-0.2.2/x86_64-redhat-linux-gnu/src/manette_resources.c:11: undefined reference to `manette_resource_data'

1. https://koji.fedoraproject.org/koji/taskinfo?taskID=33451866

Comment 2 Kalev Lember 2019-03-13 10:49:55 UTC

Thanks! Hm, not sure what's up with that. Probably something regressed with new meson 0.50 in rawhide.

It builds fine for F30 though, which I think should be good enough for now. I am sure upstream figures out the meson 0.50 issues soon.

http://koji.fedoraproject.org/koji/taskinfo?taskID=33439513 is a successful f30 scratch build from yesterday.

Comment 3 Pete Walter 2019-03-13 14:50:30 UTC

Name matches.
License matches.
Doesn't conflict.
Builds in koji.
Packaging nice and clean.
Follows guidelines.

APPROVED.

Comment 4 Gwyn Ciesla 2019-03-13 15:01:46 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libmanette

Comment 5 Kalev Lember 2019-03-13 19:32:19 UTC

Awesome, thanks for the quick reviews, both of you! Package imported and built.