Bug 1687959

Created attachment 1543326 [details]
build.log from copr

With both pytz-2018.5-2 and pytz-2018.9-1 I get the following test failure with Python 3.8.0a2 in copr:

=================================== FAILURES ===================================
________________________ PicklingTest.testDatabaseFixes ________________________

self = <test_tzinfo.PicklingTest testMethod=testDatabaseFixes>

    def testDatabaseFixes(self):
        # Hack the pickle to make it refer to a timezone abbreviation
        # that does not match anything. The unpickler should be able
        # to repair this case
        tz = pytz.timezone('Australia/Melbourne')
        p = pickle.dumps(tz)
        tzname = tz._tzname
        hacked_p = p.replace(
            _byte_string(tzname),
            _byte_string('?' * len(tzname))
        )
        self.assertNotEqual(p, hacked_p)
        unpickled_tz = pickle.loads(hacked_p)
        self.assertTrue(tz is unpickled_tz)
    
        # Simulate a database correction. In this case, the incorrect
        # data will continue to be used.
        p = pickle.dumps(tz)
        new_utcoffset = tz._utcoffset.seconds + 42
    
        # Python 3 introduced a new pickle protocol where numbers are stored in
        # hexadecimal representation. Here we extract the pickle
        # representation of the number for the current Python version.
        old_pickle_pattern = pickle.dumps(tz._utcoffset.seconds)[3:-1]
        new_pickle_pattern = pickle.dumps(new_utcoffset)[3:-1]
        hacked_p = p.replace(old_pickle_pattern, new_pickle_pattern)
    
>       self.assertNotEqual(p, hacked_p)
E       AssertionError: b'\x80\x04\x955\x00\x00\x00\x00\x00\x00\x00\x8c\x04pytz\x94\x8c\x02_p\x94\x93\x94(\x8c\x13Australia/Melbourne\x94M\xf0\x87K\x00\x8c\x03LMT\x94t\x94R\x94.' == b'\x80\x04\x955\x00\x00\x00\x00\x00\x00\x00\x8c\x04pytz\x94\x8c\x02_p\x94\x93\x94(\x8c\x13Australia/Melbourne\x94M\xf0\x87K\x00\x8c\x03LMT\x94t\x94R\x94.'

pytz/tests/test_tzinfo.py:191: AssertionError
=============== 1 failed, 232 passed, 1 skipped in 1.61 seconds ================


https://copr.fedorainfracloud.org/coprs/g/python/python3.8/build/867452/