Bug 168800

Summary:	Review Request: haddock
Product:	[Fedora] Fedora	Reporter:	Jens Petersen <petersen>
Component:	Package Review	Assignee:	Gérard Milmeister <gemi>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---	Flags:	kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://haskell.org/haddock/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-28 03:30:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Jens Petersen 2005-09-20 12:59:56 UTC

Spec Name or Url: http://people.redhat.com/petersen/haddock.spec
SRPM Name or Url: http://people.redhat.com/petersen/haddock-0.7-1.src.rpm
Description:
Haddock is a tool for automatically generating documentation from
annotated Haskell source code. It is primary intended for documenting
libraries, but it should be useful for any kind of Haskell code.

Haddock is needed to generate the documentation for ghc:
ie it is actually a buildrequire for it (currently disabled).

Comment 1 Gérard Milmeister 2005-09-23 17:52:50 UTC

Cannot download http://people.redhat.com/petersen/haddock.spec:
Permission denied.

Comment 2 Jens Petersen 2005-09-26 00:42:04 UTC

Oops, thanks Gemi for looking and sorry about that.  Should be better now. :)

Comment 3 Gérard Milmeister 2005-09-26 16:11:12 UTC

- rpmlint: W: haddock non-standard-dir-in-usr libexec
  However this is an omission of rpmlint.
- Is it necessary to include the version number in the binary and
  the data directory names.
- BuildRoot should be:
  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Does %configure not work instead of
  ./configure --prefix=%{_prefix} --libdir=%{_libdir} ?

Comment 4 Jens Petersen 2005-09-27 02:45:43 UTC

Thanks for the comments.

I dropped the versioned binary wrapper.  The version in the datadir
is also due to upstream.  I suppose it could go, but debian also has it
fwiw.

I corrected BuildRoot and made it use %configure.  Also dropped the empty
debuginfo package, and simplified the description.

http://people.redhat.com/petersen/haddock.spec-1.1

Comment 5 Gérard Milmeister 2005-09-27 09:51:17 UTC

%configure doesn't seem to work after all, the automatically
generated parameters to configure make it fail, so revert to
the previous explicit configure line.

N.B. if you create a new src rpm for the new spec, I do
not have to do it myself to submit it to mock.

Comment 6 Jens Petersen 2005-09-27 10:46:58 UTC

Hmm, I was wondering about %configure too, though it worked ok on my fc4 box.

Thanks for the careful review.  I uploaded:
http://people.redhat.com/petersen/haddock-0.7-1.2.src.rpm

Comment 7 Gérard Milmeister 2005-09-27 18:17:45 UTC

It's looking good now.
APPROVED

Comment 8 Jens Petersen 2005-09-28 03:30:59 UTC

Thank you.  haddock has been imported and built in devel.

Comment 9 Jens Petersen 2010-10-01 09:44:17 UTC

haddock is needed to build older ghc with docs.

Package Change Request
======================
Package Name: haddock
New Branches: el4
Owners: petersen
InitialCC: haskell-sig

Comment 10 Kevin Fenzi 2010-10-03 20:23:47 UTC

Git done (by process-git-requests).