Bug 1688106

Summary: Remove implementation of number of files opened in posix xlator
Product: [Community] GlusterFS Reporter: Pranith Kumar K <pkarampu>
Component: posixAssignee: bugs <bugs>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-14 04:48:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pranith Kumar K 2019-03-13 07:13:45 UTC
Description of problem:
nr_files is supposed to represent the number of files opened in posix.
Present logic doesn't seem to handle anon-fds because of which the
counts would always be wrong.
    
I don't remember anyone using this value in debugging any problem probably
because we always have 'ls -l /proc/<pid>/fd' which not only prints the
fds that are active but also prints their paths. It also handles directories
and anon-fds which actually opened the file. So it is better to remove this code instead of fixing the buggy logic to have the nr_files.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2019-03-13 08:29:46 UTC
REVIEW: https://review.gluster.org/22333 (storage/posix: Remove nr_files usage) posted (#2) for review on master by Pranith Kumar Karampuri

Comment 2 Worker Ant 2019-03-14 04:48:36 UTC
REVIEW: https://review.gluster.org/22333 (storage/posix: Remove nr_files usage) merged (#3) on master by Amar Tumballi