Bug 1688436 (rust-tokio-tls)

Summary: Review Request: rust-tokio-tls - Implementation of TLS/SSL streams for Tokio
Product: [Fedora] Fedora Reporter: Igor Raits <igor.raits>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-14 01:22:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1688437    

Description Igor Raits 2019-03-13 17:31:52 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-tls.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tokio-tls-0.2.1-1.fc31.src.rpm
Description:
An implementation of TLS/SSL streams for Tokio giving an implementation of TLS for nonblocking I/O streams.
Fedora Account System Username: ignatenkobrain

Comment 1 Robert-André Mauchin 🐧 2019-03-13 23:26:26 UTC

 - License ok
 - Latest version packaged
 - No rpmlint errors
 - Conforms to Packaging Guidelines


Test errors:


UILDSTDERR:      Running `/builddir/build/BUILD/tokio-tls-0.2.1/target/release/deps/bad-eb123c35288f6014`
running 4 tests
test expired ... FAILED
test self_signed ... FAILED
test untrusted_root ... FAILED
test wrong_host ... FAILED
failures:
---- expired stdout ----
thread 'expired' panicked at 'addr.to_socket_addrs() failed with Custom { kind: Other, error: StringError("failed to lookup address information: Name or service not known") }', tests/bad.rs:95:16
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
---- self_signed stdout ----
thread 'self_signed' panicked at 'addr.to_socket_addrs() failed with Custom { kind: Other, error: StringError("failed to lookup address information: Name or service not known") }', tests/bad.rs:95:16
---- untrusted_root stdout ----
thread 'untrusted_root' panicked at 'addr.to_socket_addrs() failed with Custom { kind: Other, error: StringError("failed to lookup address information: Name or service not known") }', tests/bad.rs:95:16
---- wrong_host stdout ----
thread 'wrong_host' panicked at 'addr.to_socket_addrs() failed with Custom { kind: Other, error: StringError("failed to lookup address information: Name or service not known") }', tests/bad.rs:95:16
failures:
    expired
    self_signed
    untrusted_root
    wrong_host
test result: FAILED. 0 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out

Comment 2 Robert-André Mauchin 🐧 2019-03-13 23:29:26 UTC
Package approved without tests.

Comment 3 Igor Raits 2019-03-14 00:20:08 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tokio-tls