Bug 1688740
| Summary: | sha512sum(1) man page is badly formatted | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Wakely <jwakely> | ||||
| Component: | coreutils | Assignee: | Kamil Dudka <kdudka> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 29 | CC: | admiller, jamartis, jarodwilson, kdudka, kzak, ooprala, ovasik, p, sebastian.kisela, svashisht, twaugh | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | coreutils-8.31-2.fc31 coreutils-8.31-2.fc30 coreutils-8.30-7.fc29 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1688744 (view as bug list) | Environment: | |||||
| Last Closed: | 2019-05-05 02:19:41 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1688744 | ||||||
| Attachments: |
|
||||||
I forgot to say that the patch was built in a rawhide mock build and all %check tests passed. Thank you for reporting the bug and preparing the patch! The original patch was applied to fix bug #406981. I will send the improved version of the patch upstream so that we do not have to keep it forever. If they reject the patch, I think it is better to drop it. Patch proposed upstream (I only tweaked it not to exceed the 80 chars line length limit): https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34856 upstream commit: https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=ae61b106 fixed in rawhide for now: https://src.fedoraproject.org/cgit/rpms/coreutils.git/commit/?id=2bc851a4 coreutils-8.31-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9ca41b62f1 coreutils-8.30-7.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-431fd850b6 coreutils-8.31-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9ca41b62f1 coreutils-8.30-7.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-431fd850b6 coreutils-8.31-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. coreutils-8.30-7.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1543984 [details] Patch to patch the patch The coreutils-6.10-manpages.patch screws up the formatting of the man page (and the note it adds to the --help output is not proper English anyway). The rendered man page looks like: -t, --text read in text mode (default) Note: There is no difference between binary and text mode option on GNU system. -z, --zero end each output line with NUL, not newline, and disable file name escaping Note that the -z option is not a new item, but continues on from the note, and there's a spurious line break after "not newline,". In the troff source the problem is a missing .TP macro and a missing newline, but the man page appears to be generated by help2man so it's not as simple as fixing the troff. Please either drop the patch completely (it seems unnecessary to me) or fix the formatting and the grammar. I've attached a patch for the patch, which moves the "Note:" to the end, so it doesn't mess up the formatting of the --text and --zero options. I also fixed the grammar.