Bug 1688932

+++ This bug was initially created as a clone of Bug #1677576 +++

Description of problem:
Fail to process the sm-notify option "-f" when converting /etc/sysconfig/nfs.
I.e.
[root]# cat /etc/sysconfig/nfs
SMNOTIFYARGS="-f"
[root]# nfsconvert
option -f not recognized
Error whilst converting SMNOTIFYARGS to nfsconf options.

Conversion failed. Please correct the error and try again.
[root]# man sm-notify | grep "\-f"
       -f     Send notifications even if sm-notify has already run since the last system reboot.
[root]# rpm -q nfs-utils
nfs-utils-2.3.3-13.el8.x86_64


Version-Release number of selected component (if applicable):
nfs-utils-2.3.3-13.el8

How reproducible:
always

Additional info:
Maybe this option is invalid and can be ignored now.
As I cannot find the corresponding param in /etc/nfs.conf:
~~~
[sm-notify]
# debug=0
# retry-time=900
# outgoing-port=
# outgoing-addr=
# lift-grace=y
~~~

(delay to 8.1 as this issue is trivial and it's too late for 8.0 now)

--- Additional comment from Steve Dickson on 2019-02-15 14:26:25 UTC ---

This is upstream problem since sm-notify does not look for
the force flag in nfs.conf.... Here is the proposed upstream
patch

https://marc.info/?l=linux-nfs&m=155023975505290&w=2

nfsconvert.py will have to be modified to deal with the flag
which look fairly easy...

--- Additional comment from Yongcheng Yang on 2019-02-18 04:31:02 UTC ---

(In reply to Steve Dickson from comment #1)
> This is upstream problem since sm-notify does not look for
> the force flag in nfs.conf.... Here is the proposed upstream
> patch
> 
> https://marc.info/?l=linux-nfs&m=155023975505290&w=2
> 
> nfsconvert.py will have to be modified to deal with the flag
> which look fairly easy...

Updating bug summary according to the above info. Thanks!

--- Additional comment from Steve Dickson on 2019-03-05 15:24:42 UTC ---

commit 3762a464a8cd7afa42e616194cc7fcd1d200c1ad
Author: Steve Dickson <steved>
Date:   Fri Mar 1 15:23:47 2019 -0500

    sm-notify: Added -f flag to nfs.conf parsing
    
    Cleaned up the nfs.conf parsing and added the setting
    of the force to the nfs.conf parsing
    
    Signed-off-by: Steve Dickson <steved>

--- Additional comment from Yongcheng Yang on 2019-03-08 09:50:01 UTC ---

Please note the patch of comment #3 has been merged in nfs-utils-2.3.3-15.el8 now.

(In reply to Steve Dickson from comment #1)
> ...
> nfsconvert.py will have to be modified to deal with the flag
> which look fairly easy...

However, the nfsconver script is still as previous and needs an update.
So I'm just removing the fixed version for now.


Testing logs:
~~~~~~~~~~~~~~~
[root.0 ~]# cat /etc/nfs.conf
[sm-notify]
# force=0
[root.0 ~]# >/var/log/messages && systemctl restart rpc-statd-notify
[root.0 ~]# grep notify /var/log/messages
Mar  8 04:43:11 8.1.0 sm-notify[38360]: Version 2.3.3 starting
Mar  8 04:43:11 8.1.0 sm-notify[38360]: Already notifying clients; Exiting! <--- by default
[root.0 ~]#
[root.0 ~]# vi /etc/nfs.conf
[root.0 ~]# cat /etc/nfs.conf
[sm-notify]
 force=1
[root.0 ~]# >/var/log/messages && systemctl restart rpc-statd-notify
[root.0 ~]# grep notify /var/log/messages
Mar  8 04:43:35 8.1.0 sm-notify[38378]: Version 2.3.3 starting  <--- No exit now
[root.0 ~]# >/var/log/messages && systemctl restart rpc-statd-notify
[root.0 ~]# grep notify /var/log/messages
Mar  8 04:43:42 8.1.0 sm-notify[38387]: Version 2.3.3 starting  <--- No exit now
[root.0 ~]# 
[root.0 ~]# >/etc/nfs.conf
[root.0 ~]# vi /etc/sysconfig/nfs
[root.0 ~]# cat /etc/sysconfig/nfs
SMNOTIFYARGS="-f"
[root.0 ~]# nfsconvert 
option -f not recognized
Error whilst converting SMNOTIFYARGS to nfsconf options.

Conversion failed. Please correct the error and try again.
~~~~~~~~~~~~~~~

--- Additional comment from Justin Mitchell on 2019-03-08 13:04 UTC ---