Bug 1688956

Summary: "Edit Labels", "Edit Annotations", etc. modals disappear and discard changes if you click outside the modal
Product: OpenShift Container Platform Reporter: Jan Kleinert <jkleiner>
Component: Management ConsoleAssignee: Steve Goodwin <sgoodwin>
Status: CLOSED DUPLICATE QA Contact: Yadan Pei <yapei>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.1.0CC: aos-bugs, jokerman, mmccomas, spadgett, yapei
Target Milestone: ---   
Target Release: 4.1.0   
Hardware: Unspecified   
OS: Mac OS   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-18 19:31:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jan Kleinert 2019-03-14 19:00:34 UTC
Description of problem: 
The Edit Labels and Edit Annotations modals (and others) will close and discard any changes a user has made, if the user clicks outside the modal. 


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Click into a deployment in the web console
2. Click the Actions button and choose Edit Labels
3. Add a label(but DON'T click Save) and then click anywhere outside the Edit Labels modal
4. Open the Edit Labels dialog again

Actual results:
The modal closes and the label that was added is not there

Expected results:
The modal does not close when a user clicks outside the modal. Only the Cancel and Save buttons close the modal.


Additional info:
I'm testing this on the shared OCPv4 RHPDS cluster. Please let me know if you need a URL to access it.

Comment 1 Yadan Pei 2019-03-18 06:11:27 UTC
Seems a dup issue with https://bugzilla.redhat.com/show_bug.cgi?id=1602331 ?

Comment 2 Samuel Padgett 2019-03-18 19:29:14 UTC
https://github.com/openshift/console/pull/1303

Comment 3 Samuel Padgett 2019-03-18 19:31:13 UTC

*** This bug has been marked as a duplicate of bug 1602331 ***

Comment 4 Samuel Padgett 2019-03-18 19:31:43 UTC
We have a fix ready, but we'll track the change under bug 1602331