Bug 1689369

Summary: [Regression][VMware] CD/DVD Drives does not list ISO files, dropdown blank
Product: Red Hat CloudForms Management Engine Reporter: Kedar Kulkarni <kkulkarn>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Kedar Kulkarni <kkulkarn>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.2CC: bmidwood, cbudzilo, dmetzger, hkataria, lavenel, mpovolny, obarenbo, simaishi, smallamp, tnovotna
Target Milestone: GAKeywords: Regression
Target Release: 5.11.0Flags: kkulkarn: automate_bug+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: vmware
Fixed In Version: 5.11.0.19 Doc Type: Enhancement
Doc Text:
This update of Red Hat CloudForms displays ISO files in the dropdown menu for CD/DVD Drives for VMware providers.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-12 13:36:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot none

Description Kedar Kulkarni 2019-03-15 17:54:56 UTC 
Created attachment 1544563 [details]
Screenshot

Description of problem:

 CD/DVD Drives does not list ISO files, dropdown blank, see screenshot. 

I have made sure to run SSA on datastore containing ISOs and I can see all the ISO files in datastore. But when I try to change the Host File in Reconfigure VM, the dropdown is empty. 

If I added the ISO file via vCenter then I can see it in CFME UI, and I can also change it, but can't do it directly in CFME without going to vCenter UI.

Version-Release number of selected component (if applicable):
5.10.2.0

How reproducible:
100%

Steps to Reproduce:
1.Add VMware Provider
2.Run Smart State Analysis on Datastores so CFME can detect available ISO files
3.Try to select a VM and reconfigure it to mount one of the ISO files from datastores

Actual results:
Can't see ISOs in Dropdown

Expected results:
I should see Dropdown populated with ISO files. 

Additional info:
This was earlier BZ https://bugzilla.redhat.com/show_bug.cgi?id=1533728 where this feature was implemented.
Comment 2 Dave Johnson 2019-03-15 18:01:07 UTC 
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.
Comment 9 CFME Bot 2019-08-06 19:36:11 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/5952
Comment 11 CFME Bot 2019-08-07 06:26:33 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/5747aff14631f9bc3b0b76f37aa8f95573c8f28f
commit 5747aff14631f9bc3b0b76f37aa8f95573c8f28f
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Aug  6 15:19:16 2019 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Aug  6 15:19:16 2019 -0400

    Fixed call that build list of Storages to build Host file drop down

    Issue was introduced in https://github.com/ManageIQ/manageiq-ui-classic/pull/3956, in commit 6df12d1079d09dd23fea2e1627b0ee3399d911ca code that builds Host file drop down was changed `vm.try(:available_iso_names)` was removed and new method `get_iso_options` was added to build the list. Changed to get all storages that the vm's host is attached to instead of all of the vm's storages

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1689369

 app/controllers/mixins/actions/vm_actions/reconfigure.rb | 4 +-
 spec/controllers/mixins/actions/vm_actions/reconfigure_spec.rb | 27 +
 2 files changed, 29 insertions(+), 2 deletions(-)
Comment 12 CFME Bot 2019-08-07 22:37:34 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/0ad6201980c1695bb82d5c794ea6b7ba4cabe379
commit 0ad6201980c1695bb82d5c794ea6b7ba4cabe379
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Wed Aug  7 02:25:31 2019 -0400
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Wed Aug  7 02:25:31 2019 -0400

    Merge pull request #5952 from h-kataria/fix_host_files_drop_down_on_reconfigure_vms

    Fixed call that build list of Storages to build Host file drop down

    (cherry picked from commit 24d94fb12fe61c91c9f1df975bb80d9a2da04c3d)

    https://bugzilla.redhat.com/show_bug.cgi?id=1689369

 app/controllers/mixins/actions/vm_actions/reconfigure.rb | 4 +-
 spec/controllers/mixins/actions/vm_actions/reconfigure_spec.rb | 27 +
 2 files changed, 29 insertions(+), 2 deletions(-)
Comment 13 Kedar Kulkarni 2019-08-16 19:12:52 UTC 
on CFME version 5.11.0.19.20190813184334_ed72c9f I was able to get the CD/DVD Dropdown to populate with iso files as expected.
Comment 15 errata-xmlrpc 2019-12-12 13:36:09 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199