Bug 1689796

Description of problem:

When you work disconnected install,

"oreg_url" does not work if the "oreg_url" format as "hostname/imagename".

Because "<hostname>/<subpath>/<imagename>" format is forced by "(len(oreg_parts) >= 3" in "lib_utils_oo_oreg_image" filter[0].

BUT, Satellite usually uses "hostname/imagename" url for container registry, as following manner.
It's required on the disconnected installation using Satellite.

  <HOSTNAME>/<ORGANIZATION>-<PRODUCT>-<REPOSITORY>
  
  For instance, if "registry.redhat.com/rhel7/etcd" image publish on the Satellite (register to Satellite as "rhel7/etcd" ),
  then the URL will be changed to "satellite.example.com/<ORGANIZATION>-<PRODUCT>-rhel7_etcd" format, and "/" is replaced with "_" on the Satellite.

Refer [1] and [2], OpenShift articles are written as prerequisite of availability "<hostname>/<imagename>" registry url on the Satellite.


[0] [ https://github.com/openshift/openshift-ansible/blob/release-3.11/roles/lib_utils/filter_plugins/oo_filters.py#L658-L663 ]
  ~~~
  oreg_parts = oreg_url.rsplit('/', 2)
  if len(oreg_parts) < 2:
      raise errors.AnsibleFilterError("oreg_url malformed: {}".format(oreg_url))
  if not (len(oreg_parts) >= 3 and '.' in oreg_parts[0]):
      # oreg_url does not include host information; we'll just return etcd default
  return image_default
  ~~~

[1] Preparing Satellite 6 for a disconnected installation 
    [https://blog.openshift.com/using-satellite-6-server-disconnect-openshift-container-platform-install/]
  ~~~
  Next, the script will supply the appropriate installation vars to insert into the OCP install playbooks:

    oreg_url: sat6.e2e.bos.redhat.com:5000/default_organization-ocp36-openshift3_ose-${component}:${version}
  ~~~
    
[2]  [https://bugzilla.redhat.com/show_bug.cgi?id=1506267#c2]
  ~~~
  As your output is saying that images like "sat6.e2e.bos.redhat.com:5000/default_organization-ocp3_disconnected-openshift3_deployer:v3.6.173.0.21" are missing I would guess that your oreg_url is including the registry, something like:
  oreg_url=sat6.e2e.bos.redhat.com:5000/default_organization-ocp3_disconnected-openshift3_${component}:${version}
  ~~~


Version-Release number of the following components:
rpm -q openshift-ansible
openshift-ansible-3.11.82-3.git.0.9718d0a.el7.noarch

rpm -q ansible
ansible-2.6.14-1.el7ae.noarch

ansible --version
ansible 2.6.14
  config file = /usr/share/ansible/openshift-ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Sep 12 2018, 05:31:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]


How reproducible:
Always, when you configure oreg_url=<hostname>/<imagename> using Satellite.


Steps to Reproduce:
1.
2.
3.

Actual results:
Some component(etcd) that used "lib_utils_oo_oreg_image" filter for oreg_url for replacement, the component is failed to pull image from "oreg_url".

Expected results:
All the image path is replaced correctly with "oreg_url" you specified on the system using Satellite.

Additional info: