Bug 1690027

Koji Fedora scratch build link was incorrect. Correct one (with systemd and vmguestlib) is http://koji.fedoraproject.org/koji/taskinfo?taskID=33611900

 - Use set_build_flags

%build
%set_build_flags
make \
%if %{defined use_vmguestlib}
    WITH_VMGUESTLIB=1 \
%else
    WITH_VMGUESTLIB=0 \
%endif
    %{?_smp_mflags}

 - Use install -p to keep timestamps:

%if %{with systemd}
mkdir -p %{buildroot}/%{_unitdir}
install -pm 755 init/%{name}.service %{buildroot}/%{_unitdir}
%else
mkdir -p %{buildroot}/%{_initrddir}
install -pm 755 init/%{name} %{buildroot}/%{_initrddir}
%endif

 - If it's only for Fedora maybe you can drop the non-systemd version? Apart from RHEL6, I don't think you'll need chkconfig stuff.

 - Ask upstream for a LICENSE file

 - The version in the header and the %changelog is not the same



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "ISC License". 5 files have unknown
     license. Detailed output of licensecheck in
     /home/bob/packaging/review/spausedd/review-spausedd/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in spausedd
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: spausedd-20190318-2.fc31.x86_64.rpm
          spausedd-debuginfo-20190318-2.fc31.x86_64.rpm
          spausedd-debugsource-20190318-2.fc31.x86_64.rpm
          spausedd-20190318-2.fc31.src.rpm
spausedd.x86_64: W: incoherent-version-in-changelog 20190321-2 ['20190318-2.fc31', '20190318-2']
spausedd.x86_64: W: empty-%postun
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

@Robert-André Mauchin

Thank you a lot for the review!


>  - Use set_build_flags
> 

This is neat feature, I didn't notice that it was added.

> %build
> %set_build_flags
> make \
> %if %{defined use_vmguestlib}
>     WITH_VMGUESTLIB=1 \
> %else
>     WITH_VMGUESTLIB=0 \
> %endif
>     %{?_smp_mflags}
> 
>  - Use install -p to keep timestamps:

Done

> 
> %if %{with systemd}
> mkdir -p %{buildroot}/%{_unitdir}
> install -pm 755 init/%{name}.service %{buildroot}/%{_unitdir}
> %else
> mkdir -p %{buildroot}/%{_initrddir}
> install -pm 755 init/%{name} %{buildroot}/%{_initrddir}
> %endif
> 
>  - If it's only for Fedora maybe you can drop the non-systemd version? Apart
> from RHEL6, I don't think you'll need chkconfig stuff.

Yep, agreed. This package is for Fedora only, so I've removed chkconfig stuff.

> 
>  - Ask upstream for a LICENSE file

I'm upstream :) so I've added both COPYING and AUTHORS files.

> 
>  - The version in the header and the %changelog is not the same

Good catch, fixed.

Fixed SRPM is https://honzaf.fedorapeople.org/spausedd/spausedd-20190319-1.fc29.src.rpm, SPEC https://honzaf.fedorapeople.org/spausedd/spausedd-20190319.spec and scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=33628072

Thank you again for the review,
  Honza

 - License file maust be installed with %license:

%files
%doc AUTHORS
%license COPYING


Package is approved but please fix the aforementioned issue before import.

@Robert-André Mauchin

Thanks for review and ACK.

I've fixed the %license so final srpm and specs which I will use for importing are:
Fixed SRPM is https://honzaf.fedorapeople.org/spausedd/spausedd-20190320-1.fc29.src.rpm, SPEC https://honzaf.fedorapeople.org/spausedd/spausedd-20190320.spec.

Thanks again!

With regards,
  Honza

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/spausedd

spausedd-20190320-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-dd47e2747b

spausedd-20190320-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4b02603aed

spausedd-20190320-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-12ac4013e8

spausedd-20190320-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4b02603aed

spausedd-20190320-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-dd47e2747b

spausedd-20190320-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-12ac4013e8

spausedd-20190320-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

spausedd-20190320-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

spausedd-20190320-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.