Bug 1690454

Summary: mount-shared-storage.sh does not implement mount options
Product: [Community] GlusterFS Reporter: mplx+redhat
Component: posix-aclAssignee: Amar Tumballi <atumball>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: mainlineCC: atumball, bugs, jthottan, skoduri
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-23 09:30:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch mount to use arg3 options
none
patch to use simplest mount cmd none

Description mplx+redhat 2019-03-19 14:05:15 UTC 
Description of problem:
mount-shared-storage.sh does not take care of mount options specified in /etc/fstab

Version-Release number of selected component (if applicable):
5.5

How reproducible:
reproducible

Steps to Reproduce:
1. add acl option to glusterfs entry in fstab
2. manually mount or mount via os means; acl is enabled
3. unmount
4. mount-shared-storage.sh mounts glusterfs; acl not enabled

Actual results:
mount-shared-storage.sh mounts without options from fstab (i.e. mount -t glusterfs /src /target)

Expected results:
mount-shared-storage.sh evaluates and uses options from fstab when mounting (i.e. mount --target /target)

Additional info:
https://github.com/gluster/glusterfs/blob/master/extras/mount-shared-storage.sh#L24
Comment 1 Amar Tumballi 2019-06-17 07:23:18 UTC 
Agree that this is an issue. We should consider Arr[3] (options) in mount command. Did you happen to resolve it? Possible to send a patch for the same?
Comment 2 mplx+redhat 2019-07-16 20:32:06 UTC 
Created attachment 1591202 [details]
patch mount to use arg3 options

patch to use arg3 as options (as requested)
Comment 3 mplx+redhat 2019-07-16 20:33:55 UTC 
Created attachment 1591203 [details]
patch to use simplest mount cmd

patch as I've in use in prod env since ~4 months where it's up to the linux system to take care of source and options according to fstab
Comment 4 Worker Ant 2019-07-18 06:51:23 UTC 
REVIEW: https://review.gluster.org/23068 (extras/mount-shared-storage.sh: consider options to mount) posted (#1) for review on master by Amar Tumballi
Comment 5 Amar Tumballi 2019-07-18 06:54:26 UTC 
Considering the patch was posted by Reporter, I have used the same email ID as 'author' in patch submitted above. Please check which email ID you need to add there if prefer to see yourself as GlusterFS contributor.
Comment 6 Worker Ant 2019-07-23 09:30:27 UTC 
REVIEW: https://review.gluster.org/23068 (extras/mount-shared-storage.sh: consider options to mount) merged (#2) on master by Amar Tumballi
Comment 7 Red Hat Bugzilla 2023-09-14 05:25:40 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days