Bug 1690753

Summary:	Volume stop when quorum not met is successful
Product:	[Community] GlusterFS	Reporter:	Kshithij Iyer <kiyer>
Component:	glusterd	Assignee:	Vishal Pandey <vpandey>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	amukherj, bugs, srakonde, vpandey
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1706893 (view as bug list)		Environment:
Last Closed:	2019-05-11 04:15:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1706893

Description Kshithij Iyer 2019-03-20 07:47:09 UTC

Description of problem:
On a 2 node cluster(N1 &N2), create one volume of type distributed. Now set cluster.server-quorum-ratio to 90% and set cluster.server-quorum-type to server. Start the volume and stop glusterd on one of the node. Now if you try to stop the volume the volumes stops successfully but ideally it shouldn't stop.

How reproducible:
5/5

Steps to Reproduce:
1. Create a cluster with 2 nodes.
2. Create a volume of type distributed.
3. Set cluster.server-quorum-ratio to 90.
4. Set server-quorum-type to server.
5. Start the volume.
6. Stop glusterd on one node.
7. Stop the volume.(Should fail!)

Actual results:
volume stop: testvol_distributed: success

Expected results:
volume stop: testvol_distributed: failed: Quorum not met. Volume operation not allowed.

Additional info:

Comment 1 Atin Mukherjee 2019-04-01 14:33:42 UTC

This looks like a bug and should be an easy fix.

Comment 2 Worker Ant 2019-05-09 09:24:18 UTC

REVIEW: https://review.gluster.org/22692 (glusterd: Add gluster volume stop operation to glusterd_validate_quorum()) posted (#1) for review on master by Vishal Pandey

Comment 4 Atin Mukherjee 2019-05-10 14:16:05 UTC

Root cause : Since the volume stop command has been ported from synctask to mgmt_v3, the quorum check was missed out in mgmt_v3 for stop volume transaction.

Comment 5 Worker Ant 2019-05-11 04:15:40 UTC

REVIEW: https://review.gluster.org/22692 (glusterd: Add gluster volume stop operation to glusterd_validate_quorum()) merged (#4) on master by Atin Mukherjee