Bug 169096

Summary:	Review Request: libmcrypt: Encryption algorithms library
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	Aurelien Bompard <gauret>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list, gauret
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://mcrypt.sourceforge.net/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-09-28 17:05:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 169098

Description Tom "spot" Callaway 2005-09-22 23:17:15 UTC

Spec Name or Url: http://www.auroralinux.org/people/spot/review/libmcrypt.spec
SRPM Name or Url: http://www.auroralinux.org/people/spot/review/libmcrypt-2.5.7-1.src.rpm
Description: 

Libmcrypt is a thread-safe library providing a uniform interface
to access several block and stream encryption algorithms.

Comment 1 Aurelien Bompard 2005-09-23 21:39:04 UTC

Wasn't there some kind of legal export restriction on mcrypt ? Has it been
resolved ? (see Cryptology item in http://fedoraproject.org/wiki/ForbiddenItems)

Comment 2 Tom "spot" Callaway 2005-09-25 21:00:58 UTC

When I audited the algorithms, I couldn't find anything.

The US cryptographic export restrictions were significantly reduced in 2000,
perhaps at one point, this would be bad, but it is now ok.

Comment 3 Konstantin Ryabitsev 2005-09-25 21:23:51 UTC

You also can't "export" a product that wasn't developed in the US. The auhtor of
mcrypt is a Greek citizen.

Comment 4 Aurelien Bompard 2005-09-26 06:22:28 UTC

Review for release 1:
* RPM name is OK
* Source libmcrypt-2.5.7.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of libmcrypt looks OK
* rpmlint of libmcrypt-devel looks OK
* File list of libmcrypt looks OK
* File list of libmcrypt-devel looks OK
* Works with mcrypt

Comment 5 Tom "spot" Callaway 2005-09-26 15:26:07 UTC

Is this an approval? Just making sure.

Comment 6 Aurelien Bompard 2005-09-26 15:35:18 UTC

Yes (I changed the blocker bug to FE-ACCEPT)