Bug 1691209

Summary: [virtio-win][netkvm+viostor]Job ”Static Tools Logo Test“ failed with build 169
Product: Red Hat Enterprise Linux 8 Reporter: Peixiu Hou <phou>
Component: virtio-winAssignee: ybendito
virtio-win sub component: virtio-win-prewhql QA Contact: Virtualization Bugs <virt-bugs>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: ailan, dkutalek, kanderso, lijin, vrozenfe, xiagao, ybendito, yvugenfi
Version: 8.2Keywords: Regression
Target Milestone: rc   
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1721243 (view as bug list) Environment:
Last Closed: 2019-07-30 14:22:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1721243    
Attachments:
Description Flags
170blk_bug_verify hck package none

Description Peixiu Hou 2019-03-21 06:55:49 UTC 
Description of problem:
Run job ”Static Tools Logo Test“ failed on win2012-r2 guest. Error message as follows:

Error 3/20/2019 11:16:17.257 AM DVL test failed:

Microsoft.StaticToolsLogo.ObjectModel.DvlException: C:\dvl\netkvm.DVL.XML: DVL file format incorrect (netkvm.x64.General.Checksum).
   at Microsoft.StaticToolsLogo.ObjectModel.DvlChecker.CheckDvl()
   at DevfundTests.DvlTest.DvlCheck()
 WexTraceInfo ThreadId=2896 ProcessId=2384 TimeStamp=13750303441 LogSessionId=1 
 

Version-Release number of selected component (if applicable):
kernel-4.18.0-74.el8.x86_64
qemu-kvm-3.1.0-18.module+el8+2834+fa8bb6e2.x86_64
seabios-1.12.0-1.module+el8+2706+3c6581b6.x86_64
virtio-win-prewhql-169

How reproducible:
100%

Steps to Reproduce:
1.Boot the guest up:
==============================================================================
/usr/libexec/qemu-kvm -name 169NIC2012R2C20 -enable-kvm -m 6G -smp 8 -uuid 74f1abbf-4202-4e32-b2e9-f644623a064d -nodefaults -cpu host,hv_stimer,hv_synic,hv_time,hv_relaxed,hv_vpindex,hv_spinlocks=0xfff,hv_vapic,hv_reset,hv-tlbflush -chardev socket,id=charmonitor,path=/tmp/169NIC2012R2C20,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=localtime,driftfix=slew -boot order=cd,menu=on -device piix3-usb-uhci,id=usb -drive file=169NIC2012R2C20,if=none,id=drive-ide0-0-0,format=raw,cache=none -device ide-drive,drive=drive-ide0-0-0,id=ide0-0-0,bus=ide.0,unit=0 -drive file=/home/kvm_autotest_root/iso/ISO/Win2012R2/en_windows_server_2012_r2_with_update_x64_dvd_6052708.iso,if=none,media=cdrom,id=drive-ide0-1-0,readonly=on,format=raw -device ide-drive,drive=drive-ide0-1-0,id=ide0-1-0,bus=ide.1,unit=0 -drive file=169NIC2012R2C20.iso,if=none,media=cdrom,id=drive-ide0-1-1,readonly=on,format=raw -device ide-cd,drive=drive-ide0-1-1,id=ide0-1-1 -netdev tap,script=/etc/qemu-ifup,downscript=no,id=hostnet0 -device e1000,netdev=hostnet0,id=net0,mac=00:52:47:3a:24:2b -device usb-tablet,id=input0 -vnc 0.0.0.0:4 -vga std -M q35 \
-device pcie-root-port,bus=pcie.0,id=root1.0,slot=1 \
-netdev tap,script=/etc/qemu-ifup1,downscript=no,id=hostnet1,vhost=on,queues=8 -device virtio-net-pci,netdev=hostnet1,id=net1,mac=00:52:74:2e:d2:87,bus=root1.0,mq=on,vectors=18
===============================================================================

2. In guest, create a directory C:\DVL.
3. Copy netkvm.DVL.XML file from virtio-win-prewhql-169 package to C:\DVL.
4. Submit the job "Static Tools Logo Test" from HCK studio.
5. Check the job result.

Actual results:
Failed

Expected results:
Passed

Additional info:
1. Tried test with netkvm.DVL.XML file from virtio-win-prewhql-162 package, the job can be passed.
2. The netkvm.DVL.XML file location is Win10\amd64\, only this directory has this file.
3. Reproduced this issue on win2012 and win2016 guest.
Comment 1 Peixiu Hou 2019-03-25 05:49:41 UTC 
On win2019 guest, no hit this issue, tested with netkvm.DVL.XML file from virtio-win-prewhql-169 package, the job can be passed.
Comment 2 Peixiu Hou 2019-03-27 08:24:23 UTC 
Hi, we also found no vioscsi.DVL.XML file in virtio-win-prewhql-169 package. 

And I have a question here:
This job "Static Tools Logo Test" is included in win2012, win2012-r2, win2016 and win2019 guest, but netkvm.DVL.XML only included in win10 directory, none in win8 or win8.1 directory, viostor.DVL.XML included in both win8 and win10 directory, we can also use viostor.DVL.XML in win8 directory to run on win2012, win2012-r2 job, so How to map tested DVL file and the guest here? 

Thanks a lot~
Peixiu
Comment 3 xiagao 2019-03-29 04:35:48 UTC 
Test job "Static Tools Logo Test" with win2019 guest + viostor driver + virtio-win-prewhql-169 package, hit similar error:

DVL test failed:
Microsoft.StaticToolsLogo.ObjectModel.DvlException: DvlChecker: Code Analysis DVL log has CA_MUSTFIX_FAILED for driver 'viostor' with the OS architecture 'x64'.
   at Microsoft.StaticToolsLogo.ObjectModel.DvlChecker.CheckDvl()
   at DevfundTests.DvlTest.DvlCheck()
 WexTraceInfo ThreadId=1448 ProcessId=2872 TimeStamp=1823504576 LogSessionId=1 

Can we track it in this bug?
Comment 4 Vadim Rozenfeld 2019-03-29 10:00:08 UTC 
(In reply to xiagao from comment #3)
> Test job "Static Tools Logo Test" with win2019 guest + viostor driver +
> virtio-win-prewhql-169 package, hit similar error:
> 
> DVL test failed:
> Microsoft.StaticToolsLogo.ObjectModel.DvlException: DvlChecker: Code
> Analysis DVL log has CA_MUSTFIX_FAILED for driver 'viostor' with the OS
> architecture 'x64'.
>    at Microsoft.StaticToolsLogo.ObjectModel.DvlChecker.CheckDvl()
>    at DevfundTests.DvlTest.DvlCheck()
>  WexTraceInfo ThreadId=1448 ProcessId=2872 TimeStamp=1823504576
> LogSessionId=1 
> 
> Can we track it in this bug?

There are probably different problems in netkvm and viostor drivers that lead to the same 
CA_MUSTFIX_FAILED result. IIRC MS use the same way to report problems for both network and 
storage adapter drivers, but the root cases can be different. It will be useful to see which 
CA rules were violated in both cases.

Best,
Vadim.
Comment 5 Yvugenfi@redhat.com 2019-04-02 08:53:43 UTC 
1. It looks that log file for vioscsi is not present

2. For viostor there are following failures:

<AssessmentScore ScoreName="viostor.x64.SDV.Rule.spcreate" ScoreValue="1" ScoreUnit="SDV_FAILED" />
<AssessmentScore ScoreName="viostor.x64.SDV.Rule.nullcheck" ScoreValue="1" ScoreUnit="SDV_FAILED" />
<AssessmentScore ScoreName="viostor.x64.SDV.Rule.checkhwstorport" ScoreValue="1" ScoreUnit="SDV_FAILED" />
Comment 6 xiagao 2019-04-02 09:04:47 UTC 
(In reply to Yan Vugenfirer from comment #5)
> 1. It looks that log file for vioscsi is not present
> 
> 2. For viostor there are following failures:
> 
> <AssessmentScore ScoreName="viostor.x64.SDV.Rule.spcreate" ScoreValue="1"
> ScoreUnit="SDV_FAILED" />
> <AssessmentScore ScoreName="viostor.x64.SDV.Rule.nullcheck" ScoreValue="1"
> ScoreUnit="SDV_FAILED" />
> <AssessmentScore ScoreName="viostor.x64.SDV.Rule.checkhwstorport"
> ScoreValue="1" ScoreUnit="SDV_FAILED" />

There is no vioscsi.DVL.XML in virtio-win-prewhql-169 build.

#  find . -name *DVL* -print
./Win10/amd64/netkvm.DVL.XML
./Win10/amd64/viostor.DVL.XML
./Win8/amd64/viostor.DVL.XML
Comment 7 ybendito 2019-04-07 06:38:08 UTC 
For each netkvm DVL failure please open c:\dvl\netkvm.DVL.XML files in Notepad and remove the last line:
<AssessmentScore ScoreName="netkvm.x64.General.Checksum" ... ScoreUnit="DVL Checksum Value" />
Please check whether this works on HCK for 2012r2, 2016 and 2019, then we'll make this change in the build
Comment 8 Vadim Rozenfeld 2019-04-10 01:56:15 UTC 
Could we please give a try to viostor and vioscsi drivers from build 170 available at 
http://download.eng.bos.redhat.com/brewroot/packages/virtio-win-prewhql/0.1/170/win/virtio-win-prewhql-0.1.zip

Thanks,
Vadim.
Comment 9 Peixiu Hou 2019-04-11 01:56:53 UTC 
(In reply to ybendito from comment #7)
> For each netkvm DVL failure please open c:\dvl\netkvm.DVL.XML files in
> Notepad and remove the last line:
> <AssessmentScore ScoreName="netkvm.x64.General.Checksum" ... ScoreUnit="DVL
> Checksum Value" />
> Please check whether this works on HCK for 2012r2, 2016 and 2019, then we'll
> make this change in the build

Hi Yan,

I'm sorry for late(our lab network hit a serious issue, caused we have not any machine to test this issue before).

Tried with remove c:\dvl\netkvm.DVL.XML last line, tested with virtio-win-prewhql-170:
1. Tested on win2012-r2  ---Passed(tried with last line cannot be passed, without last line can be passed)
2. Tested on win2016     ---Passed(tried with last line cannot be passed, without last line can be passed)
3. Tested on win2019     ---Passed(tried with last line and without last line, both can be passed)

Best Regards~
Peixiu
Comment 10 Peixiu Hou 2019-04-11 02:54:27 UTC 
(In reply to Vadim Rozenfeld from comment #8)
> Could we please give a try to viostor and vioscsi drivers from build 170
> available at 
> http://download.eng.bos.redhat.com/brewroot/packages/virtio-win-prewhql/0.1/
> 170/win/virtio-win-prewhql-0.1.zip
> 
> Thanks,
> Vadim.

Hi Vadim,

1. For viostor tests:
Tried Test with virtio-win-prewhql-170 on win2012-r2, also reproduced this issue.
Tried Test with virtio-win-prewhql-170 on win2012-r2 and tried to remove the c:\dvl\viostor.DVL.XML file last line, the job can be passed.
Tried Test with virtio-win-prewhql-170 on win2016, reproduced this issue.
Tried Test with virtio-win-prewhql-170 on win2016 and tried to remove the c:\dvl\viostor.DVL.XML file last line, the job can be passed.
Tried Test with virtio-win-prewhql-170 on win2019, it can be passed(both with and without c:\dvl\viostor.DVL.XML file last line, the job can be passed).

2. For vioscsci tests:
Tried Test with virtio-win-prewhql-170 on win2012-64, reproduced this issue.
Tried Test with virtio-win-prewhql-170 on win2012-64 and tried to remove the c:\dvl\vioscsi.DVL.XML file last line, the job can be passed.
Tried Test with virtio-win-prewhql-170 on win2016, reproduced this issue.
Tried Test with virtio-win-prewhql-170 on win2016 and tried to remove the c:\dvl\vioscsi.DVL.XML file last line, the job can be passed.
Tried Test with virtio-win-prewhql-170 on win2019, it can be passed(both with and without c:\dvl\vioscsi.DVL.XML file last line, the job can be passed).

Best Regards~
Peixiu
Comment 11 Vadim Rozenfeld 2019-04-11 03:08:47 UTC 
(In reply to Peixiu Hou from comment #10)
> (In reply to Vadim Rozenfeld from comment #8)
> > Could we please give a try to viostor and vioscsi drivers from build 170
> > available at 
> > http://download.eng.bos.redhat.com/brewroot/packages/virtio-win-prewhql/0.1/
> > 170/win/virtio-win-prewhql-0.1.zip
> > 
> > Thanks,
> > Vadim.
> 
> Hi Vadim,
> 
> 1. For viostor tests:
> Tried Test with virtio-win-prewhql-170 on win2012-r2, also reproduced this
> issue.
> Tried Test with virtio-win-prewhql-170 on win2012-r2 and tried to remove the
> c:\dvl\viostor.DVL.XML file last line, the job can be passed.
> Tried Test with virtio-win-prewhql-170 on win2016, reproduced this issue.
> Tried Test with virtio-win-prewhql-170 on win2016 and tried to remove the
> c:\dvl\viostor.DVL.XML file last line, the job can be passed.
> Tried Test with virtio-win-prewhql-170 on win2019, it can be passed(both
> with and without c:\dvl\viostor.DVL.XML file last line, the job can be
> passed).
> 
> 2. For vioscsci tests:
> Tried Test with virtio-win-prewhql-170 on win2012-64, reproduced this issue.
> Tried Test with virtio-win-prewhql-170 on win2012-64 and tried to remove the
> c:\dvl\vioscsi.DVL.XML file last line, the job can be passed.
> Tried Test with virtio-win-prewhql-170 on win2016, reproduced this issue.
> Tried Test with virtio-win-prewhql-170 on win2016 and tried to remove the
> c:\dvl\vioscsi.DVL.XML file last line, the job can be passed.
> Tried Test with virtio-win-prewhql-170 on win2019, it can be passed(both
> with and without c:\dvl\vioscsi.DVL.XML file last line, the job can be
> passed).
> 

By the last line, do you mean one started with
"vioscsi.x64.General.Checksum" ?
Could you please post the the test results (or the entire package file)?
I just want to be sure that I'm not missing anything.

Best regards,
Vadim.

> Best Regards~
> Peixiu
Comment 12 Peixiu Hou 2019-04-11 03:42:55 UTC 
Created attachment 1554393 [details]
170blk_bug_verify hck package
Comment 13 Peixiu Hou 2019-04-11 03:45:59 UTC 
(In reply to Vadim Rozenfeld from comment #11)
> (In reply to Peixiu Hou from comment #10)
> > (In reply to Vadim Rozenfeld from comment #8)
> > > Could we please give a try to viostor and vioscsi drivers from build 170
> > > available at 
> > > http://download.eng.bos.redhat.com/brewroot/packages/virtio-win-prewhql/0.1/
> > > 170/win/virtio-win-prewhql-0.1.zip
> > > 
> > > Thanks,
> > > Vadim.
> > 
> > Hi Vadim,
> > 
> > 1. For viostor tests:
> > Tried Test with virtio-win-prewhql-170 on win2012-r2, also reproduced this
> > issue.
> > Tried Test with virtio-win-prewhql-170 on win2012-r2 and tried to remove the
> > c:\dvl\viostor.DVL.XML file last line, the job can be passed.
> > Tried Test with virtio-win-prewhql-170 on win2016, reproduced this issue.
> > Tried Test with virtio-win-prewhql-170 on win2016 and tried to remove the
> > c:\dvl\viostor.DVL.XML file last line, the job can be passed.
> > Tried Test with virtio-win-prewhql-170 on win2019, it can be passed(both
> > with and without c:\dvl\viostor.DVL.XML file last line, the job can be
> > passed).
> > 
> > 2. For vioscsci tests:
> > Tried Test with virtio-win-prewhql-170 on win2012-64, reproduced this issue.
> > Tried Test with virtio-win-prewhql-170 on win2012-64 and tried to remove the
> > c:\dvl\vioscsi.DVL.XML file last line, the job can be passed.
> > Tried Test with virtio-win-prewhql-170 on win2016, reproduced this issue.
> > Tried Test with virtio-win-prewhql-170 on win2016 and tried to remove the
> > c:\dvl\vioscsi.DVL.XML file last line, the job can be passed.
> > Tried Test with virtio-win-prewhql-170 on win2019, it can be passed(both
> > with and without c:\dvl\vioscsi.DVL.XML file last line, the job can be
> > passed).
> > 
> 
> By the last line, do you mean one started with
> "vioscsi.x64.General.Checksum" ?
> Could you please post the the test results (or the entire package file)?
> I just want to be sure that I'm not missing anything.
> 

Yes, as Yan mentioned on comment#7, tried with remove the c:\dvl\*.DVL.XML file last line:
<AssessmentScore ScoreName="netkvm.x64.General.Checksum" ... ScoreUnit="DVL Checksum Value" />
And I upload a hck package as attachment.

Best Regards~
Peixiu

> Best regards,
> Vadim.
> 
> > Best Regards~
> > Peixiu
Comment 14 Vadim Rozenfeld 2019-04-14 23:47:25 UTC 
can we please give a try to build 171 
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=878998 ?

Thanks,
Vadim.
Comment 15 Peixiu Hou 2019-04-15 05:08:37 UTC 
(In reply to Vadim Rozenfeld from comment #14)
> can we please give a try to build 171 
> https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=878998 ?
> 

Hi Vadim,

I tried test with build 171 on 2 guests:

1. For viostor, tried test with virtio-win-prewhql-171 on win2012-r2, also reproduced this issue.
2. For vioscsi, tried test with virtio-win-prewhql-171 on win2016 guest, also reproduced this issue.

Best Regards~
Peixiu

> Thanks,
> Vadim.
Comment 16 ybendito 2019-04-15 06:15:57 UTC 
(In reply to Peixiu Hou from comment #15)
> (In reply to Vadim Rozenfeld from comment #14)
> > can we please give a try to build 171 
> > https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=878998 ?
> > 
> 
> Hi Vadim,
> 
> I tried test with build 171 on 2 guests:
> 
> 1. For viostor, tried test with virtio-win-prewhql-171 on win2012-r2, also
> reproduced this issue.
> 2. For vioscsi, tried test with virtio-win-prewhql-171 on win2016 guest,
> also reproduced this issue.
> 

The ZIP file contains 2 XML files for each driver:
{drivername}.dvl.xml which is suitable for 2019
{drivername}.dvl-compat.xml which is suitable for 2016 and earlier
Comment 17 Peixiu Hou 2019-04-15 06:51:05 UTC 
(In reply to ybendito from comment #16)
> (In reply to Peixiu Hou from comment #15)
> > (In reply to Vadim Rozenfeld from comment #14)
> > > can we please give a try to build 171 
> > > https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=878998 ?
> > > 
> > 
> > Hi Vadim,
> > 
> > I tried test with build 171 on 2 guests:
> > 
> > 1. For viostor, tried test with virtio-win-prewhql-171 on win2012-r2, also
> > reproduced this issue.
> > 2. For vioscsi, tried test with virtio-win-prewhql-171 on win2016 guest,
> > also reproduced this issue.
> > 
> 
> The ZIP file contains 2 XML files for each driver:
> {drivername}.dvl.xml which is suitable for 2019
> {drivername}.dvl-compat.xml which is suitable for 2016 and earlier

1. For viostor, tried test with virtio-win-prewhql-171 on win2012-r2, renamed C:\DVL\viostor.DVL-compat.xml file to C:\DVL\viostor.DVL.XML, it can be passed.
2. For vioscsi, tried test with virtio-win-prewhql-171 on win2016 guest, renamed C:\DVL\vioscsi.DVL-compat.xml file to C:\DVL\vioscsi.DVL.XML, it can be passed.
3. For netkvm, tried test with virtio-win-prewhql-171 on win2012 guest, renamed C:\DVL\netkvm.DVL-compat.xml file to C:\DVL\netkvm.DVL.XML, it can be passed.

As upper results, the bug has been fixed~

Thanks a lot~
Peixiu
Comment 18 Peixiu Hou 2019-04-15 07:25:28 UTC 
Hi, I also have a question here:

For win2012-64 and win2012-r2 guest, which directory file should be used for this job?

For netkvm, netkvm.DVL-compat.xml is included in virtio-win-prewhql-171\Win10 directory.
For vioscsi/viostor, viostor.DVL-compat.xml/vioscsi.DVL-compat.xml is included in both virtio-win-prewhql-171\Win10 and virtio-win-prewhql-171\Win8.

If we use file in Win10 directory to run this job is ok?

Thanks a lot~
Peixiu
Comment 19 ybendito 2019-04-15 14:14:58 UTC 
(In reply to Peixiu Hou from comment #18)
> Hi, I also have a question here:
> 
> For win2012-64 and win2012-r2 guest, which directory file should be used for
> this job?
> 
> For netkvm, netkvm.DVL-compat.xml is included in
> virtio-win-prewhql-171\Win10 directory.
> For vioscsi/viostor, viostor.DVL-compat.xml/vioscsi.DVL-compat.xml is
> included in both virtio-win-prewhql-171\Win10 and
> virtio-win-prewhql-171\Win8.
> 
> If we use file in Win10 directory to run this job is ok?

For netkvm - this is OK

For viostor/vioscsi - I think Vadim will answer
Comment 20 Vadim Rozenfeld 2019-04-19 09:06:29 UTC 
Both (Win10 and Win8) should provide the same results.
We should be able to use Win10 for Win2012 (R2), but
we can also use one from Win8 sub-directory as well.
So, I wolud say it is absolutely up to you which one
to pick up.

Best regards,
Vadim.
Comment 25 errata-xmlrpc 2019-07-30 14:22:06 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1997