Bug 1691271

Summary: NAME is not necessary for kubefed2 enable command
Product: OpenShift Container Platform Reporter: Qin Ping <piqin>
Component: FederationAssignee: Ivan Font <ifont>
Status: CLOSED CURRENTRELEASE QA Contact: Qin Ping <piqin>
Severity: low Docs Contact:
Priority: low    
Version: 4.1.0CC: pmorie
Target Milestone: ---   
Target Release: 4.1.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-17 15:31:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Qin Ping 2019-03-21 09:58:01 UTC
Description of problem:
NAME is not necessary for kubefed2 enable command, but looks from the 'kubefed2 enable help', it's necessary.

Version-Release number of selected component (if applicable):
kubefed2 version: version.Info{Version:"0.0.6", GitCommit:"de6a0a909418f5ddf2d04d232b0ca55aa9cffb49", GitTreeState:"clean", BuildDate:"2019-03-14T00:43:37Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}


How reproducible:
100%

Steps to Reproduce:
1. kubefed2 enable --federation-namespace=default -f deployment.yaml
$ cat deployment.yaml 
apiVersion: core.federation.k8s.io/v1alpha1
kind: EnableTypeDirective
metadata:
  name: deployments.apps


Actual results:
No NAME given here. deployment federation enabled successfully.

Expected results:


Additional info:

Comment 1 Ivan Font 2019-04-09 22:28:14 UTC
I've filed an upstream issue to resolve various kubefed2 option issues including the one captured by this bugzilla:

https://github.com/kubernetes-sigs/federation-v2/issues/738

Comment 2 Ivan Font 2019-04-11 01:34:41 UTC
Upstream PR for fix: https://github.com/kubernetes-sigs/federation-v2/pull/739

Comment 3 Ivan Font 2019-05-13 19:03:16 UTC
Fixed in version 0.0.10.

Comment 4 Qin Ping 2019-05-14 08:02:20 UTC
Verified with:

$ ./kubefedctl version
kubefedctl version: version.Info{Version:"v0.0.10-dirty", GitCommit:"71d233ede685707df554ef653e06bf7f0229415c", GitTreeState:"dirty", BuildDate:"2019-05-06T22:30:31Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}