Bug 1691579

Summary:	DISA STIG does not recognize options on removable partitions
Product:	Red Hat Enterprise Linux 7	Reporter:	Ryan Mullett <rmullett>
Component:	scap-security-guide	Assignee:	Jan Černý <jcerny>
Status:	CLOSED ERRATA	QA Contact:	Matus Marhefka <mmarhefk>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.6	CC:	ggasparb, jcerny, matyc, mhaicman, openscap-maint, wsato
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	scap-security-guide-0.1.49-5.el7	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-29 19:52:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ryan Mullett 2019-03-22 00:36:24 UTC

Description of problem:
For the 
xccdf_org.ssgproject.content_rule_mount_option_nodev_removable_partitions
xccdf_org.ssgproject.content_rule_mount_option_noexec_removable_partitions
xccdf_org.ssgproject.content_rule_mount_option_nosuid_removable_partitions
rules from DISA STIG, the check does not appear to properly recognize when partitions are configured with the proper nodev,nosuid, and noexec options. It also does not properly remediate with the --remediate flag. 

Version-Release number of selected component (if applicable):
openscap-1.2.17-2.el7.x86_64
scap-security-guide-0.1.40-12.el7.noarch
openscap-scanner-1.2.17-2.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. have an fstab with a /dev/cdrom or some other removable media entry, like this:
/dev/cdrom /media/cdrom iso9660 ro,noauto,nosuid,noexec,nodev 0 0                                       

2. attempt to remediate with DISA STIG:
   # oscap xccdf eval --remediate --profile stig-rhel7-disa --results results.xml --report report.html /usr/share/xml/scap/ssg/content/ssg-rhel7-xccdf.xml 

Actual results:
The following three rule fail even when fstab has the proper flags in place:
xccdf_org.ssgproject.content_rule_mount_option_nodev_removable_partitions
xccdf_org.ssgproject.content_rule_mount_option_noexec_removable_partitions
xccdf_org.ssgproject.content_rule_mount_option_nosuid_removable_partitions

Expected results:
One of three things:

1. The scan will properly remediate if the options on the line are not correct for removable media and the --remediate flag is used

2. The scan will recognize that the nodev option is configured within fstab and will flag as a pass

3. The report.html will show proper remediation steps to resolve the issue 

Additional info:

Comment 8 Watson Yuuma Sato 2019-08-23 12:54:08 UTC

I think the fix is not to require that "removable partitions" be mounted, after all, a removable partition may not be there all the time.
The rule should just check if the partition is configured to be mounted correctly.

Comment 9 Matěj Týč 2020-04-20 16:33:52 UTC

Issue has been addressed in https://github.com/ComplianceAsCode/content/pull/5278

Comment 16 errata-xmlrpc 2020-09-29 19:52:12 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (scap-security-guide bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3909