Bug 169191

Summary: compiler notices dodgy code
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: kexec-toolsAssignee: Jeff Moyer <jmoyer>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-26 20:18:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description David Binderman 2005-09-24 11:23:36 UTC
Description of problem:
I just tried to compile Fedora development package kexec-tools-1.101-2
with the extra compiler flag -Wall.

The compiler said

kexec/arch/i386/crashdump-x86.c:311: warning: 'temp_region.type' is used
uninitialized in this function

The source code is

                memmap_p[tidx+1] = temp_region;

It might be worthwhile to ensure that the whole of local data structure
temp_region is initialised to something sensible shortly after it is
defined, thus making sure that all execution paths get a sensible value
of local variable "temp_region".


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jeff Moyer 2005-09-26 20:18:43 UTC
Please take this issue up with the upstream maintainers.