Bug 1692863

Summary: Datepicker field allows to enter alphanumeric text, no validation against the text
Product: Red Hat CloudForms Management Engine Reporter: Beate Guldenschuh-Bihannic <beate.guldenschuh-bihannic>
Component: UI - OPSAssignee: Roman Blanco <rblanco>
Status: CLOSED CURRENTRELEASE QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.0CC: bmidwood, dmetzger, gmccullo, hkataria, jprause, lavenel, mkanoor, mpovolny, mshriver, obarenbo, rmahique, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.11.0Flags: mfeifer: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.14 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1726388 (view as bug list) Environment:
Last Closed: 2019-12-13 15:01:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1704905, 1726388    
Attachments:
Description Flags
image which describes problem none

Description Beate Guldenschuh-Bihannic 2019-03-26 15:31:38 UTC
Created attachment 1548123 [details]
image which describes problem

Description of problem:
Datepicker field allows to enter alphanumeric text, no validation against the text

Version-Release number of selected component (if applicable):
5.10.0.33.20190129203322_85a1e4e

How reproducible:
Create a service dialog with a datepicker field. Enter an alphanumeric value into the field (eg. "test"), the submit button will still be active and no validation of the content happens

Steps to Reproduce:
1. create a new service dialog with a datepicker field
2. add the service dialog to the catalog
3. in the service catalog select the service dialog and click on order
4. Clear the date from the field and enter "test" in the datepicker field
5. the Submit Button is still active and no validation of the invalid content happens

Actual results:
no validation on invalid datepicker field content 
Expected results:
the field validation tells, that the content "test" is not a valid date

Additional info:

Comment 2 Dave Johnson 2019-03-26 16:01:09 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 6 Roman Blanco 2019-06-10 16:55:16 UTC
Fix: https://github.com/ManageIQ/ui-components/pull/392

Comment 9 CFME Bot 2019-07-02 20:29:53 UTC
New commit detected on ManageIQ/ui-components/master:

https://github.com/ManageIQ/ui-components/commit/799c80900e834e0d6e13656e274e3d7f7bda3547
commit 799c80900e834e0d6e13656e274e3d7f7bda3547
Author:     Roman Blanco <rblanco>
AuthorDate: Mon Jun 10 12:51:04 2019 -0400
Commit:     Roman Blanco <rblanco>
CommitDate: Mon Jun 10 12:51:04 2019 -0400

    Mark datepicker field as valid only if it's value is an instance of Date

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1692863

 src/dialog-user/services/dialogData.ts | 8 +-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comment 10 Niyaz Akhtar Ansari 2019-07-17 07:14:16 UTC
Verified in Version 5.11.0.14.20190710225033_cb17ff0