Bug 1693385

Summary: request to change the version of fedora in fedora-smoke-job
Product: [Community] GlusterFS Reporter: Amar Tumballi <atumball>
Component: project-infrastructureAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: mainlineCC: bugs, gluster-infra, mscherer, pasik, sankarshan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-16 05:01:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Amar Tumballi 2019-03-27 17:35:16 UTC
Description of problem:

There are at least 2 jobs which use 'fedora' while running smoke.

https://build.gluster.org/job/devrpm-fedora/ && https://build.gluster.org/job/fedora-smoke/

I guess we are running Fedora 28 in both of these, would be good to update it to higher version, say F29 (and soon F30).



Version-Release number of selected component (if applicable):
master



Additional info:
Would be good to remove '--enable-debug' in these builds on some jobs (there are 2 smoke, and 4 rpm build jobs). We should remove --enable-debug in at least 1 of these, so our release RPMs which has no DEBUG defined, can be warning free.

Comment 1 M. Scherer 2019-03-27 17:48:25 UTC
So, that requires to upgrade the builders (or reinstall them), I think it would be better to wait on F30 to do it only once.

Comment 2 Niels de Vos 2019-03-28 15:09:47 UTC
(In reply to Amar Tumballi from comment #0)
> Description of problem:
...
> Would be good to remove '--enable-debug' in these builds on some jobs (there
> are 2 smoke, and 4 rpm build jobs). We should remove --enable-debug in at
> least 1 of these, so our release RPMs which has no DEBUG defined, can be
> warning free.

I do not think these jobs are used for the RPMs that get marked as 'released' and land on download.gluster.org.

Comment 3 Amar Tumballi 2019-03-28 15:26:24 UTC
Agree, I was asking for a job without DEBUG mainly because a few times, there may be warning without DEBUG being there during compile (ref: https://review.gluster.org/22347 && https://review.gluster.org/22389 )

As I had --enable-debug while testing locally, never saw the warning, and none of the smoke tests captured the error. If we had a job without --enable-debug, we could have seen the warning while compiling, which would have failed Smoke.

Comment 4 sankarshan 2019-05-27 01:47:48 UTC
(In reply to Amar Tumballi from comment #3)
> Agree, I was asking for a job without DEBUG mainly because a few times,
> there may be warning without DEBUG being there during compile (ref:
> https://review.gluster.org/22347 && https://review.gluster.org/22389 )
> 
> As I had --enable-debug while testing locally, never saw the warning, and
> none of the smoke tests captured the error. If we had a job without
> --enable-debug, we could have seen the warning while compiling, which would
> have failed Smoke.

Is the request here to have a job without --enable-debug? Attempting to understand this because there has not been much updates or, clarity on the work. Also, Fedora 30 is now GA - https://fedoramagazine.org/announcing-fedora-30/

Comment 5 Amar Tumballi 2019-05-27 03:53:59 UTC
First request in this bug is:

* Change the version of Fedora (currently 28) to 30.
  - This can't be done without some head start time, because there are some 20-30 warnings with newer compiler version. We need to fix it before making the job to vote.
  - Best way is to have a job which doesn't vote (skip), but reports failure/success for at least a week or so. In that time, we fix all the warning, make the job GREEN, and then make it vote.

* `--enable-debug` is used everywhere in smoke tests, but release bits doesn't involve the same. Hence, I was thinking of having at least 1 of the smoke jobs not have it. Probably we should consider opening another bug for the same. It can be done in fedora-smoke, or even in centos-smoke. doesn't matter.

Comment 6 Amar Tumballi 2019-07-16 05:01:42 UTC
Looks like this is done now.

(Ref: https://lists.gluster.org/pipermail/gluster-devel/2019-July/056400.html)