Bug 1693653

Summary:	Enable LV thinpool on VDO devices
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	SATHEESARAN <sasundar>
Component:	rhhi	Assignee:	Sahina Bose <sabose>
Status:	CLOSED ERRATA	QA Contact:	bipin <bshetty>
Severity:	high	Docs Contact:
Priority:	medium
Version:	rhhiv-1.6	CC:	godas, guillaume.pavese, pasik, rhs-bugs, sabose
Target Milestone:	---	Keywords:	Improvement, ZStream
Target Release:	RHHI-V 1.6.z Async Update
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Thinly provisioned bricks are now supported on top of Virtual Disk Optimization (VDO) devices.	Story Points:	---
Clone Of:
Clones:	1693657 (view as bug list)		Environment:
Last Closed:	2019-10-03 12:23:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1693657
Bug Blocks:

Description SATHEESARAN 2019-03-28 12:23:57 UTC

Description of problem:
------------------------
Till RHHI-V 1.6, thinpool on VDO devices are disabled, because of discard problems[1] with thinpool  and VDO combination. This issue will be resolved with the update VDO systemd unit file, that enables the proper value of max_discard_sectors for VDO. This fix will be part of gluster-ansible bug[2] and once that is fixed, RHHI-V cockpit deployment should enable thinpool on top of VDO devices.

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=1600156
[2] - https://bugzilla.redhat.com/show_bug.cgi?id=1690606

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
cockpit-ovirt-dashboard-0.12.6
RHVH-4.3
gluster-ansible-roles-1.0.3-3

How reproducible:
------------------
Not Applicable

Steps to Reproduce:
-------------------
Not applicable

Actual results:
----------------
When VDO is selected on the brick, thinp gets disabled

Expected results:
-----------------
When selecting VDO, thinpool should not get disabled


Additional info:

Comment 1 SATHEESARAN 2019-03-28 12:24:53 UTC

Note of Caution:
-----------------

Do not fix this bug, till the gluster-ansible bug[1] is fixed

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=1690606

Comment 2 Sahina Bose 2019-05-07 14:33:50 UTC

*** Bug 1634551 has been marked as a duplicate of this bug. ***

Comment 5 Yaniv Kaul 2019-07-22 08:22:14 UTC

(In reply to SATHEESARAN from comment #1)
> Note of Caution:
> -----------------
> 
> Do not fix this bug, till the gluster-ansible bug[1] is fixed
> 
> [1] - https://bugzilla.redhat.com/show_bug.cgi?id=1690606

The above is fixed. Now can we fix this one?

Comment 6 Sahina Bose 2019-07-22 10:06:14 UTC

Updating status to reflect the dependent bug

Comment 7 bipin 2019-08-29 03:47:49 UTC

Tested the bug with cockpit-ovirt-dashboard-0.13.6-1.el7ev.noarch.

Tested the below:
================
* Check the enable dedupe and compression button,the thinpool is enabled. 
* After successful gluster deployment, could see thinpool is enabled with VDO devices

Based on above results moving the bug as verified

Comment 9 errata-xmlrpc 2019-10-03 12:23:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2963