Bug 1693657

Summary: Enable LV thinpool on VDO devices
Product: [oVirt] cockpit-ovirt Reporter: SATHEESARAN <sasundar>
Component: gluster-ansibleAssignee: Gobinda Das <godas>
Status: CLOSED CURRENTRELEASE QA Contact: bipin <bshetty>
Severity: high Docs Contact:
Priority: high    
Version: 0.12.6CC: bshetty, bugs, guillaume.pavese, pasik, rhs-bugs, sabose
Target Milestone: ovirt-4.3.6Keywords: ZStream
Target Release: 0.13.6Flags: sasundar: ovirt-4.3?
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.13.6 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1693653 Environment:
Last Closed: 2019-09-26 19:43:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1693653    

Description SATHEESARAN 2019-03-28 12:27:01 UTC 
Description of problem:
------------------------
Till RHHI-V 1.6, thinpool on VDO devices are disabled, because of discard problems[1] with thinpool  and VDO combination. This issue will be resolved with the update VDO systemd unit file, that enables the proper value of max_discard_sectors for VDO. This fix will be part of gluster-ansible bug[2] and once that is fixed, RHHI-V cockpit deployment should enable thinpool on top of VDO devices.

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=1600156
[2] - https://bugzilla.redhat.com/show_bug.cgi?id=1690606

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
cockpit-ovirt-dashboard-0.12.6
RHVH-4.3
gluster-ansible-roles-1.0.3-3

How reproducible:
------------------
Not Applicable

Steps to Reproduce:
-------------------
Not applicable

Actual results:
----------------
When VDO is selected on the brick, thinp gets disabled

Expected results:
-----------------
When selecting VDO, thinpool should not get disabled

Note of Caution:
-----------------

Do not fix this bug, till the gluster-ansible bug[1] is fixed

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=1690606
Comment 1 SATHEESARAN 2019-06-14 06:41:25 UTC 
gluster-ansible-roles should provide VDO systemd unit file that should help in enabling VDO + thinpool
Comment 2 SATHEESARAN 2019-06-18 10:28:16 UTC 
(In reply to SATHEESARAN from comment #1)
> gluster-ansible-roles should provide VDO systemd unit file that should help
> in enabling VDO + thinpool

Because of this reason, it would be preferable to have this fix targeted for ovirt-4.3.6
Comment 3 bipin 2019-08-29 03:47:24 UTC 
Tested the bug with cockpit-ovirt-dashboard-0.13.6-1.el7ev.noarch.

Tested the below:
================
* Check the enable dedupe and compression button,the thinpool is enabled. 
* After successful gluster deployment, could see thinpool is enabled with VDO devices

Based on above results moving the bug as verified
Comment 4 Sandro Bonazzola 2019-09-26 19:43:07 UTC 
This bugzilla is included in oVirt 4.3.6 release, published on September 26th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.6 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.