Bug 1693692
| Summary: | Increase code coverage from regression tests | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Amar Tumballi <atumball> |
| Component: | core | Assignee: | bugs <bugs> |
| Status: | CLOSED UPSTREAM | QA Contact: | |
| Severity: | urgent | Docs Contact: | |
| Priority: | high | ||
| Version: | mainline | CC: | bugs, pasik, ykaul |
| Target Milestone: | --- | Keywords: | CodeChange, Tracking, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://build.gluster.org/job/line-coverage/lastCompletedBuild/Line_20Coverage_20Report/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-03-12 14:29:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Amar Tumballi
2019-03-28 13:45:07 UTC
I'd start with the important code, for example, code that is ~50%: https://build.gluster.org/job/line-coverage/Line_20Coverage_20Report/xlators/mgmt/glusterd/src/glusterd-op-sm.c.gcov.html https://build.gluster.org/job/line-coverage/Line_20Coverage_20Report/xlators/mgmt/glusterd/src/glusterd-brick-ops.c.gcov.html https://build.gluster.org/job/line-coverage/Line_20Coverage_20Report/xlators/mgmt/glusterd/src/glusterd-geo-rep.c.gcov.html Critical, core components, or features (geo-rep), which have 50-60%. We can see whole functions not be called. REVIEW: https://review.gluster.org/22441 (tests: add statedump to playground) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22442 (tests: add a tests for trace xlator) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22443 (sdfs: enable pass-through) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22444 (protocol: add an option to force using old-protocol) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22455 (posix-acl: remove default functions, and use library fn instead) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22458 (tests: enhance the auth.allow test to validate all failures of 'login' module) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22441 (tests: add statedump to playground) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22455 (posix-acl: remove default functions, and use library fn instead) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22443 (sdfs: enable pass-through) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22491 (tests: make sure to traverse all of meta dir) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22442 (tests: add a tests for trace xlator) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22444 (protocol: add an option to force using old-protocol) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22491 (tests: make sure to traverse all of meta dir) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22550 (tests: write a tests for testing strings in volfile) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22551 (tests: add tests for monitoring) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22456 (marker-quota: remove dead code) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/22597 (tests: add .t file to increase cli code coverage) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/22598 (tier: remove tier code to increase code coverage in cli) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/22599 (tests: add .t files to increase cli code coverage) posted (#1) for review on master by Rishubh Jain REVIEW: https://review.gluster.org/22597 (tests: add .t file to increase cli code coverage) merged (#7) on master by Sanju Rakonde REVIEW: https://review.gluster.org/22599 (tests: add .t files to increase cli code coverage) merged (#4) on master by Rishubh Jain REVIEW: https://review.gluster.org/22621 (nl-cache:add test to increase code coverage) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/22598 (tier/cli: remove tier code to increase code coverage in cli) merged (#8) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22629 (libglusterfs: remove compound-fop helper functions) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22627 (performance/decompounder: remove the translator as the feature is not used anymore) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22630 (tests: add .t files to increase cli code coverage) posted (#1) for review on master by Rishubh Jain REVIEW: https://review.gluster.org/22631 (tests/cli: add .t file to increase line coverage in cli) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/22627 (performance/decompounder: remove the translator as the feature is not used anymore) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22628 (protocol: remove compound fop) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/22621 (nl-cache:add test to increase code coverage) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22629 (libglusterfs: remove compound-fop helper functions) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/22630 (tests: add .t files to increase cli code coverage) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22631 (tests/cli: add .t file to increase line coverage in cli) merged (#3) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22664 (glusterd/tier: remove tier related code from glusterd) posted (#1) for review on master by hari gowtham REVIEW: https://review.gluster.org/22550 (tests: validate volfile grammar - strings in volfile) merged (#9) on master by Amar Tumballi REVIEW: https://review.gluster.org/22458 (tests: enhance the auth.allow test to validate all failures of 'login' module) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/22753 (tests/quick-read-with-upcall.t: increase the timeout) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22753 (tests/quick-read-with-upcall.t: increase the timeout) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22664 (glusterd/tier: remove tier related code from glusterd) merged (#8) on master by Amar Tumballi REVIEW: https://review.gluster.org/22779 (lcov: improve line coverage) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22780 (code-coverage: improve it on shard, trace and posix xlators) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22551 (tests: add tests for different signal handling) merged (#12) on master by Xavi Hernandez REVIEW: https://review.gluster.org/22779 (marker: remove some unused functions) merged (#5) on master by Xavi Hernandez REVIEW: https://review.gluster.org/22789 (lcov: improve line coverage) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22792 (lcov: more coverage to shard, old-protocol, sdfs) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22792 (lcov: more coverage to shard, old-protocol, sdfs) merged (#1) on master by Amar Tumballi REVIEW: https://review.gluster.org/22794 (tests/geo-rep: Add tests to cover glusterd geo-rep) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/22794 (tests/geo-rep: Add tests to cover glusterd geo-rep) merged (#2) on master by Kotresh HR REVIEW: https://review.gluster.org/22799 (lcov: run more fops on translators) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22803 (tests/geo-rep: Add geo-rep glusterd test cases) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/22789 (lcov: improve line coverage) merged (#2) on master by Xavi Hernandez REVIEW: https://review.gluster.org/22803 (tests/geo-rep: Add geo-rep glusterd test cases) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22799 (lcov: run more fops on translators) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22818 (tests/geo-rep: Add geo-rep cli testcases) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/22818 (tests/geo-rep: Add geo-rep cli testcases) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/22887 (lcov: add more tests to glfsxmp-coverage) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22887 (lcov: add more tests to glfsxmp-coverage) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23098 (error-gen: increase coverage by reducing error-rate) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23099 (gfapi: increase function-coverage) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23100 (quiesce: add missing fops) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23100 (quiesce: add missing fops) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23122 (trace: add more coverage by testing it with glfs-coverage too.) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23128 (tests: heal-info add --xml option for more coverage) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23122 (trace: add more coverage by testing it with glfs-coverage too.) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23098 (error-gen: increase coverage by reducing error-rate) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23128 (tests: heal-info add --xml option for more coverage) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23099 (gfapi: increase function-coverage) merged (#7) on master by Amar Tumballi REVIEW: https://review.gluster.org/23133 (glusterfsd: minor enhancements) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23139 (lcov: check for zerofill/discard fops on arbiter) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23139 (lcov: check for zerofill/discard fops on arbiter) merged (#1) on master by Amar Tumballi REVIEW: https://review.gluster.org/23141 (xdr: add code so we have more xdr functions covered) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/23141 (xdr: add code so we have more xdr functions covered) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23159 (tests/line-coverage: more commands added to cover xdrs) posted (#1) for review on master by Amar Tumballi This bug is moved to https://github.com/gluster/glusterfs/issues/1052, and will be tracked there from now on. Visit GitHub issues URL for further details |